update sqlfluff action to use latest version

Author: alistairewj

.github/workflows/lint_sqlfluff.yml

@@ -1,49 +1,43 @@
 name: SQLFluff
 
 on:
-  - pull_request
+  - push
 
 jobs:
   lint-mimic-iv:
     runs-on: ubuntu-latest
     steps:
       - name: checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - name: Install Python
-        uses: "actions/setup-python@v2"
+        uses: actions/setup-python@v5
         with:
-          python-version: "3.7"
+          python-version: "3.12"
       - name: install sqlfluff
-        run: "pip install sqlfluff==1.4.5"
+        run: "pip install sqlfluff==3.5.0"
       - name: Get changed files
         id: get_file_changes
         uses: trilom/[email protected]
         with:
           output: ' '
       - name: Get changed .sql files in mimic-iv concepts folder
         id: get_files_to_lint
-        shell: bash -l {0}
+        shell: bash
         run: |
-          # Set the command in the $() brackets as an output to use in later steps
-          echo "lintees=$(
-          echo \
-          $(echo ${{ steps.get_file_changes.outputs.files_modified }} |
-          tr -s ' ' '\n' |
-          grep -E '^mimic-iv/concepts/.*[.]sql$' |
-          tr -s '\n' ' ') \
-          $(echo ${{ steps.get_file_changes.outputs.files_added }} |
-          tr -s ' ' '\n' |
-          grep -E '^mimic-iv/concepts/.*[.]sql$' |
-          tr -s '\n' ' ')
-          ) >> $GITHUB_OUTPUT"
+          # Compose list of changed SQL files under mimic-iv/concepts and export to step output
+          files="$(echo "${{ steps.get_file_changes.outputs.files_modified }} ${{ steps.get_file_changes.outputs.files_added }}" \
+            | tr -s ' ' '\n' \
+            | grep -E '^mimic-iv/concepts/.*[.]sql$' \
+            | tr -s '\n' ' ')"
+          echo "lintees=${files}" >> "$GITHUB_OUTPUT"
 
       - name: Lint SQL files
         id: sqlfluff_json
         if: steps.get_files_to_lint.outputs.lintees != ''
-        shell: bash -l {0}
+        shell: bash
         run: sqlfluff lint --format github-annotation --annotation-level failure --nofail ${{ steps.get_files_to_lint.outputs.lintees }} > annotations.json
       - name: Annotate
-        uses: yuzutech/annotations-action@v0.3.0
+        uses: yuzutech/annotations-action@v0.5.0
         with:
           repo-token: "${{ secrets.GITHUB_TOKEN }}"
           title: "SQLFluff Lint"

.sqlfluff

@@ -1,20 +1,21 @@
-[sqlfluff:core]
-rules = core,L019
-large_file_skip_byte_limit = 40000
+[sqlfluff]
 dialect = bigquery
+large_file_skip_byte_limit = 40000
+exclude_rules = LT02
+
+# Enable core rules plus explicit layout.commas (leading commas)
+[sqlfluff:core]
+rules = core,layout.commas
 
 [sqlfluff:layout:type:comma]
 line_position = leading
 
-[sqlfluff:indentation]
-indented_joins = false
-indented_using_on = true
-template_blocks_indent = false
-
-[sqlfluff:rules:L010]
-# Keywords should be upper case
+# Capitalisation rules
+[sqlfluff:rules:capitalisation.keywords]
 capitalisation_policy = upper
 
-[sqlfluff:rules:L030]
-# Functions should be upper case
-extended_capitalisation_policy = upper
+[sqlfluff:rules:capitalisation.functions]
+extended_capitalisation_policy = upper
+
+[sqlfluff:rules:capitalisation.identifiers]
+extended_capitalisation_policy = lower