Merge pull request #202 from MITLibraries/bug-remove-appt-end-date-from-key

Remove end date as part of appointment unique key

Author: ghukill

hrqb/tasks/employee_appointments.py

@@ -104,7 +104,6 @@ def get_dataframe(self) -> pd.DataFrame:
                 row.mit_id,
                 row.position_id,
                 row.appt_begin_date,
-                row.appt_end_date,
             ),
             axis=1,
         )
@@ -139,14 +138,12 @@ def generate_merge_key(
         mit_id: str,
         position_id: str,
         appt_begin_date: str,
-        appt_end_date: str,
     ) -> str:
         return md5_hash_from_values(
             [
                 mit_id,
                 position_id,
                 appt_begin_date,
-                appt_end_date,
             ]
         )
 

hrqb/tasks/employee_leave.py

@@ -56,7 +56,6 @@ def get_dataframe(self) -> pd.DataFrame:
                 row.mit_id,
                 row.position_id,
                 row.appt_begin_date,
-                row.appt_end_date,
             ),
             axis=1,
         )

hrqb/tasks/employee_salary_history.py

@@ -50,7 +50,6 @@ def get_dataframe(self) -> pd.DataFrame:
                 row.mit_id,
                 row.position_id,
                 row.appt_begin_date,
-                row.appt_end_date,
             ),
             axis=1,
         )

tests/conftest.py

@@ -790,7 +790,7 @@ def task_shared_extract_qb_employee_appointments_complete(all_tasks_pipeline_nam
                     "Related Employee Type": "Admin Staff",
                     "Union Name": "Le Union",
                     "Exempt / NE": "E",
-                    "Key": "868ce513323c5391ae8afaa0ceb70c69",
+                    "Key": "00f6099d6777bd9b6985bf86eeb3e449",
                 }
             ]
         )

tests/tasks/test_employee_appointments.py

@@ -102,6 +102,5 @@ def test_task_transform_employee_appointments_key_expected_from_row_data(
             row["MIT ID"],
             row["Position ID"],
             row["Begin Date"],
-            row["End Date"],
         ]
     )