From 23de8c4485685adee213820760318de16bb1e3d8 Mon Sep 17 00:00:00 2001 From: jazairi <16103405+jazairi@users.noreply.github.com> Date: Mon, 17 Mar 2025 15:46:30 -0400 Subject: [PATCH] Add integrity hashes for remote scripts and stylesheets Why these changes are being introduced: It's good practice to validate checksums for external libraries. We've done this in individual apps, but it makes sense to make the change in the theme gem. Relevant ticket(s): * [ENGX-290](https://mitlibraries.atlassian.net/browse/ENGX-290) How this addresses that need: This adds `integrity`, `crossorigin`, and `referrerpolicy` attributes for remotely hosted scripts and stylesheets. Side effects of this change: I'm not totally sure how to exhaustively test these changes. I've confirmed that the scripts/stylesheets load as expected, and checked the changes locally in a few of our apps. That feels like enough, but just signaling the uncertainty here in case the reviewer has additional insight. --- app/views/layouts/_head.html.erb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/views/layouts/_head.html.erb b/app/views/layouts/_head.html.erb index 61631e7..31715e2 100644 --- a/app/views/layouts/_head.html.erb +++ b/app/views/layouts/_head.html.erb @@ -7,8 +7,8 @@ <%= yield :additional_meta_tag %> - - + + <%= stylesheet_link_tag "application", :media => "all" %> @@ -19,7 +19,7 @@ <%= render partial: "layouts/js_exception_handler" %> <%= javascript_include_tag "application" %> - + <%= yield :additional_js %>