Skip to content

Commit 8f2d068

Browse files
authored
Merge pull request #104 from MITLibraries/TIMX-241-springshare-oai-dates
Timx 241 springshare oai dates
2 parents 094c0df + 9c28431 commit 8f2d068

File tree

5 files changed

+14
-12
lines changed

5 files changed

+14
-12
lines changed

Pipfile.lock

+6-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/test_oai_dc.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,5 +74,5 @@ def test_oaidc_generic_date():
7474
transformer_instance = OaiDc("libguides", input_records)
7575
xml = next(transformer_instance.input_records)
7676
assert transformer_instance.get_dates("test_source_record_id", xml) == [
77-
timdex.Date(kind=None, note=None, range=None, value="2008-06-19T17:55:27")
77+
timdex.Date(kind="Unknown", note=None, range=None, value="2008-06-19T17:55:27")
7878
]

tests/test_springshare.py

+5-3
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,9 @@ def test_springshare_get_dates_valid():
6060
for xml in transformer_instance.input_records:
6161
date_field_value = transformer_instance.get_dates("test_get_dates", xml)
6262
assert date_field_value == [
63-
timdex.Date(kind=None, note=None, range=None, value="2000-01-01T00:00:00")
63+
timdex.Date(
64+
kind="Created", note=None, range=None, value="2000-01-01T00:00:00"
65+
)
6466
]
6567

6668

@@ -106,7 +108,7 @@ def test_libguide_transform_with_all_fields_transforms_correctly():
106108
)
107109
],
108110
dates=[
109-
timdex.Date(value="2008-06-19T17:55:27"),
111+
timdex.Date(value="2008-06-19T17:55:27", kind="Created"),
110112
],
111113
format="electronic resource",
112114
identifiers=[
@@ -160,7 +162,7 @@ def test_research_databases_transform_with_all_fields_transforms_correctly():
160162
"researchdatabases. https://libguides.mit.edu/llba",
161163
content_type=["researchdatabases"],
162164
dates=[
163-
timdex.Date(value="2022-01-28T22:15:37"),
165+
timdex.Date(value="2022-01-28T22:15:37", kind="Created"),
164166
],
165167
format="electronic resource",
166168
identifiers=[

transmogrifier/sources/oaidc.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ def get_dates(self, source_record_id: str, xml: Tag) -> Optional[List[timdex.Dat
137137
date_str,
138138
source_record_id,
139139
):
140-
dates.append(timdex.Date(value=date_str))
140+
dates.append(timdex.Date(value=date_str, kind="Unknown"))
141141
return dates or None
142142

143143
def get_links(self, source_record_id: str, xml: Tag) -> Optional[List[timdex.Link]]:

transmogrifier/sources/springshare.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ def get_dates(self, source_record_id: str, xml: Tag) -> Optional[List[timdex.Dat
5151
date_iso_str,
5252
source_record_id,
5353
):
54-
dates.append(timdex.Date(value=date_iso_str, kind=None))
54+
dates.append(timdex.Date(value=date_iso_str, kind="Created"))
5555
return dates or None
5656

5757
def get_links(self, source_record_id: str, xml: Tag) -> Optional[List[timdex.Link]]:

0 commit comments

Comments
 (0)