Skip to content

Commit 8e6d60e

Browse files
authored
Don't attempt to parse different request types: fixes adding new experiences (#65)
Only use form data, and fix experience test to also use form data
1 parent 5307cc3 commit 8e6d60e

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

app.py

+3-6
Original file line numberDiff line numberDiff line change
@@ -124,13 +124,10 @@ def experience():
124124
return jsonify([exp.__dict__ for exp in data["experience"]]), 200
125125

126126
if request.method == "POST":
127-
request_body = (
128-
request.form
129-
if request.content_type == "multipart/form-data"
130-
else request.get_json()
131-
)
127+
request_body = request.form
128+
132129
if not request_body:
133-
return jsonify({"error": "Request must be JSON or include form data"}), 400
130+
return jsonify({"error": "Request must include form data"}), 400
134131

135132
required_fields = {
136133
"title": str,

test_pytest.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ def test_experience(client):
6969
"description": "Writing JavaScript Code",
7070
"logo": "default.jpg",
7171
}
72-
item_id = client.post("/resume/experience", json=example_experience).json["id"]
72+
item_id = client.post("/resume/experience", data=example_experience).json["id"]
7373
response = client.get("/resume/experience")
7474
assert any(exp["id"] == item_id for exp in response.json)
7575

0 commit comments

Comments
 (0)