Skip to content

Possible bug in batch duration calculation: duration can be longer than the render that's observed in the timeline #124

@taneliang

Description

@taneliang

From #123:

I suspect there's a bug in our batch duration calculation, because the zoom to method often zooms to an empty space. This is not a bug in the zooming: the view is zoomed to a range that matches the batch duration displayed in the tooltip.

image

Perhaps caused by the lack of render cancelled marks (MLH-Fellowship/react#30)?

Update 19 Aug

Seems like getBatchRange just sets the range's end time to the start time of the next batch. Is this intentional/correct?

for (i; i < measures.length; i++) {
const measure = measures[i];
stopTime = measure.timestamp;
if (measure.batchUID !== batchUID) {
break;
}
}

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions