ENH: cleanup of line_covered, make sure strings are not truncated (mocov_line_covered.c:191)

Author: Nikolaas N. Oosterhof

MOcov/mocov_line_covered.c

@@ -68,15 +68,15 @@ typedef struct {
 
 // Declare constants
 // (these should not be changed unless you really know what you are doing)
-const int GENERAL_STRING_BUFFER_LENGHTH = 100;
-const int MAX_ERROR_ID_LENGTH = GENERAL_STRING_BUFFER_LENGHTH;
-const int MAX_ERROR_MESSAGE_LENGTH = GENERAL_STRING_BUFFER_LENGHTH;
+#define GENERAL_STRING_BUFFER_LENGTH 100
+#define MAX_ERROR_ID_LENGTH 200
+#define MAX_ERROR_MESSAGE_LENGTH GENERAL_STRING_BUFFER_LENGTH
 
 const char *ERROR_ID_PREFIX = "mocov_line_covered:";
 const char *MALLOC_ERROR_MESSAGE_PREFIX = "memory allocation failed: ";
 
 #if IS_DEBUG
-const int DEBUG_BUFFER_SIZE = GENERAL_STRING_BUFFER_LENGHTH;
+const int DEBUG_BUFFER_SIZE = GENERAL_STRING_BUFFER_LENGTH;
 const char *DEBUG_PREFIX = "DEBUG: ";
 #endif
 
@@ -441,7 +441,7 @@ void return_state(const mxArray *prhs[], int nlhs, mxArray *plhs[]) {
                         "This function accepts at most one output.");
 
     } else if (nlhs == 0) {
-        // No output, nothing to do, we can exit this function
+        // No output, nothing to do, we can exit this function early.
         return;
     }
 
@@ -622,7 +622,7 @@ void set_state(const mxArray *prhs[], int nlhs, mxArray *plhs[]) {
     debug_print_state();
 }
 
-// Helper function to handle nrhs == 4 case (update the state with a specific
+// Helper function to handle nrhs == 3 case (update the state with a specific
 // line state)
 void update_state(const mxArray *prhs[], int nlhs, mxArray *plhs[]) {
 
@@ -641,8 +641,6 @@ void update_state(const mxArray *prhs[], int nlhs, mxArray *plhs[]) {
     debug("call 3 args");
     add_line_covered(idx, prhs[1], line_number);
 
-    // free fn pointer after use
-    // free(fn);
     debug("updating state: done, state is now");
     debug_print_state();
 }
@@ -659,9 +657,7 @@ void mexFunction(int nlhs, mxArray *plhs[], int nrhs, const mxArray *prhs[]) {
     }
 
     if (nrhs == 3) {
-        // Update the state for a specific line in a file.
-        // Optimization: because `nrhs == 4` is the most frequently used
-        // use of this function, this is checked first.
+        // Most common case: update the state for a specific line in a file.
         update_state(prhs, nlhs, plhs);
     } else if (nrhs == 1) {
         // Set the state from a struct s with s.keys and s.line_count