Skip to content

Commit 4c227b2

Browse files
committed
insertPointFrom(): remove useless argument
1 parent f7c38b2 commit 4c227b2

File tree

3 files changed

+32
-6
lines changed

3 files changed

+32
-6
lines changed

doc/source/doxygen-docs/changelog.md

Lines changed: 28 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,33 @@
11
\page changelog Change Log
22

3-
# Version 2.15.0: UNRELEASED
4-
- None yet
3+
# Version 2.15.3: UNRELEASED
4+
- Changes in libraries:
5+
- \ref mrpt_maps_grp
6+
- mrpt::maps::CPointsMap::insertPointFrom() removed first argument (sourceMap) since it's now useless using the insertionContext.
7+
8+
# Version 2.15.2: Released Nov 19th, 2025
9+
- Changes in libraries:
10+
- \ref mrpt_maps_grp
11+
- mrpt::maps::CGenericPointsMap now supports fields of type `double` too.
12+
- Others:
13+
- Fix appstreamcli warnings for metainfo files
14+
15+
# Version 2.15.1: Released Oct 29th, 2025
16+
- Bug fixes:
17+
- FIX: Avoid throw when viewing and describing as text a PCD with an empty field.
18+
- Avoid cmake errors when disabling libraries required by some unit tests.
19+
20+
# Version 2.15.0: Released Oct 26th, 2025
21+
- Changes in apps:
22+
- RawLogViewer:
23+
- Show stats for mrpt::maps::CGenericPoinsMap.
24+
- GUI options to colorize clouds by any point cloud field.
25+
- Changes in libraries:
26+
- \ref mrpt_maps_grp
27+
- Add new mrpt::maps::CGenericPointsMap
28+
- Refactor around mrpt::maps::CPointsMap for more efficient generic insertion of maps in others with arbitrary per-point fields.
29+
- Build system:
30+
- Completely remove any connection to ROS1 in this repository.
531

632
# Version 2.14.16: Released Oct 15th, 2025
733
- Changes in libraries:

modules/mrpt_maps/include/mrpt/maps/CPointsMap.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ class CPointsMap :
215215
const auto ctx = this->prepareForInsertPointsFrom(obj);
216216
for (size_t i = 0; i < N; i++)
217217
{
218-
insertPointFrom(obj, i, ctx);
218+
insertPointFrom(i, ctx);
219219
}
220220
}
221221

@@ -839,13 +839,13 @@ class CPointsMap :
839839

840840
/** Prepare efficient data structures for repeated insertion from another point map with
841841
* insertPointFrom() */
842-
InsertCtx prepareForInsertPointsFrom(const CPointsMap& source) const;
842+
[[nodiscard]] InsertCtx prepareForInsertPointsFrom(const CPointsMap& source) const;
843843

844844
/** Generic method to copy *all* applicable point properties from
845845
* one map to another, e.g. timestamp, intensity, etc.
846846
* \note Before calling this in a loop, make sure of calling registerPointFieldsFrom()
847847
*/
848-
void insertPointFrom(const CPointsMap& source, size_t sourcePointIndex, const InsertCtx& ctx)
848+
void insertPointFrom(size_t sourcePointIndex, const InsertCtx& ctx)
849849
{
850850
const size_t i = sourcePointIndex;
851851
insertPointFast((*ctx.xs_src)[i], (*ctx.ys_src)[i], (*ctx.zs_src)[i]);

modules/mrpt_maps/src/maps/CPointsMap.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1544,7 +1544,7 @@ void CPointsMap::insertAnotherMap(
15441544
if (pt.x != pt.x) continue;
15451545

15461546
// Add to this map:
1547-
this->insertPointFrom(*otherMap, srcIdx, ctx);
1547+
this->insertPointFrom(srcIdx, ctx);
15481548

15491549
// and overwrite the XYZ, if needed:
15501550
if (!identity_tf)

0 commit comments

Comments
 (0)