Ensure binary mode in temporary stringstreams

Author: jlblancoc

libs/maps/src/maps/CColouredOctoMap.cpp

@@ -90,7 +90,7 @@ void CColouredOctoMap::serializeTo(mrpt::serialization::CArchive& out) const
   out << genericMapParams;                    // v2
 
   // v2->v3: remove CMemoryChunk
-  std::stringstream ss;
+  std::stringstream ss(std::ios::in | std::ios::out | std::ios::binary);
   m_impl->m_octomap.writeBinaryConst(ss);
   const std::string& buf = ss.str();
   out << buf;
@@ -122,7 +122,7 @@ void CColouredOctoMap::serializeFrom(mrpt::serialization::CArchive& in, uint8_t
 
       if (!buf.empty())
       {
-        std::stringstream ss;
+        std::stringstream ss(std::ios::in | std::ios::out | std::ios::binary);
         ss.str(buf);
         ss.seekg(0);
         m_impl->m_octomap.readBinary(ss);

libs/maps/src/maps/COctoMap.cpp

@@ -84,7 +84,7 @@ void COctoMap::serializeTo(mrpt::serialization::CArchive& out) const
   this->renderingOptions.writeToStream(out);  // Added in v1
   out << genericMapParams;
   // v2->v3: remove CMemoryChunk
-  std::stringstream ss;
+  std::stringstream ss(std::ios::in | std::ios::out | std::ios::binary);
   const_cast<octomap::OcTree*>(&m_impl->m_octomap)->writeBinary(ss);
   const std::string& buf = ss.str();
   out << buf;
@@ -116,7 +116,7 @@ void COctoMap::serializeFrom(mrpt::serialization::CArchive& in, uint8_t version)
 
       if (!buf.empty())
       {
-        std::stringstream ss;
+        std::stringstream ss(std::ios::in | std::ios::out | std::ios::binary);
         ss.str(buf);
         ss.seekg(0);
         m_impl->m_octomap.readBinary(ss);

libs/maps/src/maps/serializations_unittest.cpp

@@ -83,25 +83,31 @@ TEST(SerializeTestMaps, WriteReadToMem)
       CLASS_ID(CPlanarLaserScan),
   };
 
-  for (auto& lstClasse : lstClasses)
+  for (auto& classInfo : lstClasses)
   {
     try
     {
       CMemoryStream buf;
       auto arch = mrpt::serialization::archiveFrom(buf);
+      std::cout << "Serializing " << classInfo->className << "...";
       {
-        auto o = mrpt::ptr_cast<CSerializable>::from(lstClasse->createObject());
+        auto o = mrpt::ptr_cast<CSerializable>::from(classInfo->createObject());
         arch << *o;
         o.reset();
       }
+      std::cout << "OK.\n";
+
+      std::cout << "  Deserializing it...";
 
       CSerializable::Ptr recons;
       buf.Seek(0);
       arch >> recons;
+
+      std::cout << "OK.\n";
     }
     catch (const std::exception& e)
     {
-      GTEST_FAIL() << "Exception during serialization test for class '" << lstClasse->className
+      GTEST_FAIL() << "Exception during serialization test for class '" << classInfo->className
                    << "':\n"
                    << e.what() << endl;
     }