Skip to content

Commit 2feb5de

Browse files
MRiabovqwencoder
andcommitted
(spec) Update devtools, integration catalog, and motor actuation migration spec
- Refresh devtools spec for current CLI surface - Add new integration test IDs to catalog - Update solution-motor-actuation-backend-parity migration notes Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
1 parent 5a9d829 commit 2feb5de

3 files changed

Lines changed: 16 additions & 14 deletions

File tree

specs/devtools.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ The integration runner is a real-stack boundary contract, not a synthetic test h
6363

6464
### Severity classification
6565

66-
- Devtool integration tests should be classified as `p1` or `p2` by default; `p0` is reserved for exceptional cases only.
66+
- Devtool integration tests should be classified as `p1` or `p2` priority by default; `p0` priority is reserved for exceptional cases only.
6767

6868
### Public entrypoint
6969

specs/integration-test-list.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,8 @@ This section is the smallest must-pass set. Keep it narrowly scoped, determinist
146146
| INT-218 | Skill catalog overlay precedence | `suggested_skills/` entries shadow canonical `skills/` entries when resolving skill reads and catalog entries, with overlay duplicates taking precedence over the approved tree. |
147147
| INT-219 | Skill overlay promotion publication contract | The promotion arbiter publishes the session overlay into canonical `skills/`, records the approved base commit and resulting promotion commit, and persists a traceable promotion record. |
148148
| INT-220 | Skill overlay promotion conflict gate | Dirty canonical repo state or unresolved overlay conflicts fail closed, do not publish a commit, and still emit a promotion record with the conflict reason. |
149+
| INT-222 | Skill overlay seeding replay contract | A retained skill-training session seeds `suggested_skills/` from the canonical `skills/` snapshot, records the approved base commit and repository root metadata, and resolves later reads against the seeded overlay first. |
150+
| INT-223 | Skill overlay deletion publication contract | A seeded overlay promotion applies deletions as part of the session diff, records the deleted paths in the promotion result, and removes deleted files from canonical `skills/` on publication. |
149151
| INT-066 | Fluid-on-electronics failure coupling | In electromechanical simulations with fluids enabled, fluid contact with powered electrical components triggers electrical failure state and benchmark failure/penalty path. |
150152
| INT-067 | Steerability exact-pointing + mention payload contract | Face/edge/vertex/part/subassembly selections and `@`-mentions are accepted over API/UI boundary, preserved in prompt payload, and observable in run traces/events used by the agent. |
151153
| INT-068 | Line-targeted steering contract | `@path/file.py:start-end` style references resolve and provide the exact requested code span to the agent context in the majority path; invalid ranges fail with explicit user-visible validation errors. |

specs/migrations/minor/solution-motor-actuation-backend-parity.md

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -225,41 +225,41 @@ The safe order is:
225225

226226
### Contract
227227

228-
- [ ] Lock the solution motor contract in `AssemblyDefinition` and the moving
228+
- [x] Lock the solution motor contract in `AssemblyDefinition` and the moving
229229
part mapping.
230230
- [ ] Keep the MuJoCo reference behavior stable while the parity work lands.
231-
- [ ] Define the Genesis motor materialization strategy from the same shared
231+
- [x] Define the Genesis motor materialization strategy from the same shared
232232
contract.
233-
- [ ] Add the visible motor example to the new `electromechanics-syntax` skill
233+
- [x] Add the visible motor example to the new `electromechanics-syntax` skill
234234
if authors need a concrete reference.
235235

236236
### Runtime
237237

238-
- [ ] Materialize solution motors as real controllable DOFs in Genesis.
239-
- [ ] Normalize `apply_control()`, `get_actuator_state()`, and
238+
- [x] Materialize solution motors as real controllable DOFs in Genesis.
239+
- [x] Normalize `apply_control()`, `get_actuator_state()`, and
240240
`get_all_actuator_names()` across backends.
241241
- [ ] Keep power gating and overload monitoring backend-agnostic.
242-
- [ ] Fail closed on unresolved or unsupported motor mappings.
243-
- [ ] Keep the validation and file-validation path fail-closed on missing or
242+
- [x] Fail closed on unresolved or unsupported motor mappings.
243+
- [x] Keep the validation and file-validation path fail-closed on missing or
244244
incompatible motor mappings before simulation starts.
245245

246246
### Validation
247247

248248
- [ ] Preserve the shared validation path that turns moving parts into
249249
controller inputs.
250-
- [ ] Add a validation failure for missing or invalid motor mappings before
250+
- [x] Add a validation failure for missing or invalid motor mappings before
251251
simulation starts.
252252
- [ ] Make the validation failure surface the same motor identity and control
253253
mode context that the simulation path uses.
254254

255255
### Tests
256256

257-
- [ ] Add or refresh integration tests for a motorized solution on MuJoCo.
258-
- [ ] Add or refresh integration tests for the same solution contract on
257+
- [x] Add or refresh integration tests for a motorized solution on MuJoCo.
258+
- [x] Add or refresh integration tests for the same solution contract on
259259
Genesis.
260-
- [ ] Add negative integration coverage for unresolved motor mappings.
261-
- [ ] Add regression coverage for unpowered and overloaded motors.
262-
- [ ] Refresh `specs/integration-test-list.md` so the solution-motor parity row
260+
- [x] Add negative integration coverage for unresolved motor mappings.
261+
- [x] Add regression coverage for unpowered and overloaded motors.
262+
- [x] Refresh `specs/integration-test-list.md` so the solution-motor parity row
263263
is explicit and tied to the actual integration coverage.
264264

265265
### Docs

0 commit comments

Comments
 (0)