Refactor Firebase functions to implement lazy initialization for calculation utilities and document processors, enhancing resource management

Author: Novapool

firebase.json

@@ -6,6 +6,7 @@
   "functions": [
     {
       "source": "functions-node",
+      "codebase": "nodejs",
       "ignore": [
         "node_modules",
         ".git",

functions-node/calculateGrade.js

@@ -3,10 +3,6 @@ const admin = require('firebase-admin');
 const { getLetterGrade } = require('./utils/gradeUtils');
 const { calculateExactGradeStatistics, generateGradeAnalysis } = require('./utils/calculationUtils');
 
-// We'll use lazy initialization for calculation utilities
-// This will ensure they're only loaded when needed
-console.log('calculateGrade module loaded - calculation utilities will be initialized on first use');
-
 /**
  * Cloud Function to calculate current grade based on submitted assignments
  */

functions-node/formatDocumentsData.js

@@ -3,10 +3,6 @@ const admin = require('firebase-admin');
 const { DOCUMENT_TYPES, normalizeDocumentType } = require('./utils/documentUtils');
 const { formatSyllabusData, formatGradesData, formatTranscriptData, combineFormattedData } = require('./utils/documentProcessors');
 
-// We'll use lazy initialization for document processors
-// This will ensure they're only loaded when needed
-console.log('formatDocumentsData module loaded - processors will be initialized on first use');
-
 /**
  * Formats all document data using multiple OpenAI API calls to ensure consistent structure
  * @param {string} userId - The user ID

functions-node/index.js

@@ -11,15 +11,9 @@ const { formatDocumentsData } = require('./formatDocumentsData');
 const { DOCUMENT_TYPES, normalizeDocumentType } = require('./utils/documentUtils');
 const corsMiddleware = require('./utils/corsMiddleware');
 
-// Create a global variable to track initialization status
-let adminInitialized = false;
-
-// Initialize Firebase Admin - this is lightweight and needed for all functions
+// Initialize Firebase Admin
 admin.initializeApp();
 
-// We'll use lazy initialization for heavier resources in each function
-console.log('Firebase Functions initialized with lazy loading pattern');
-
 // Export functions
 exports.calculateCurrentGrade = calculateCurrentGrade;
 exports.predictFinalGrade = predictFinalGrade;

functions-node/predictGrade.js

@@ -5,12 +5,6 @@ const { getLetterGrade } = require('./utils/gradeUtils');
 const { getOpenAIApiKey } = require('./utils/apiUtils');
 const { calculateExactGradeStatistics, formatDataForAIPrediction } = require('./utils/calculationUtils');
 
-// Global variable to store the OpenAI client instance
-let openaiClient = null;
-
-// We'll use lazy initialization instead of onInit
-console.log('predictGrade module loaded - OpenAI client will be initialized on first use');
-
 /**
  * Cloud Function to predict final grade using AI
  */
@@ -77,14 +71,13 @@ exports.predictFinalGrade = functions.https.onCall(async (data, context) => {
  * @returns {Promise<Object>} Prediction result
  */
 async function getAIPrediction(data) {
-  // Lazy initialization of OpenAI client
-  if (!openaiClient) {
-    console.log('Initializing OpenAI client on first use');
-    const apiKey = getOpenAIApiKey();
-    openaiClient = new OpenAI({
-      apiKey: apiKey
-    });
-  }
+  // Get API key
+  const apiKey = getOpenAIApiKey();
+  
+  // Initialize OpenAI client
+  const openai = new OpenAI({
+    apiKey: apiKey
+  });
 
   // Create a highly structured prompt with clear JSON instructions
   const prompt = `
@@ -127,7 +120,7 @@ RESPOND ONLY WITH VALID JSON IN THIS EXACT FORMAT:
   try {
     console.log('Calling OpenAI API for prediction');
     // Call OpenAI with strict instruction for JSON
-    const response = await openaiClient.chat.completions.create({
+    const response = await openai.chat.completions.create({
       model: "gpt-4o-mini",
       messages: [
         {