Moving $urlHelper definition

rominail · rominail · commit 00819a0bdfd9 · 2026-06-11T13:29:27.000-04:00
diff --git a/module/VuFind/src/VuFind/AjaxHandler/GetItemStatuses.php b/module/VuFind/src/VuFind/AjaxHandler/GetItemStatuses.php
@@ -386,7 +386,6 @@ protected function getItemStatusGroup($record, $callnumberSetting)
         }
 
         if (isset($this->getThis)) {
-            $urlHelper = $this->renderer->plugin('url');
             $this->getThis->setItems($record);
         }
         // Build list split out by location:
@@ -407,6 +406,7 @@ protected function getItemStatusGroup($record, $callnumberSetting)
             ) {
                 $itemIdParams = !empty($locationStatus['item_id'])
                     ? ['query' => ['item_id' => $locationStatus['item_id']]] : null;
+                $urlHelper ??= $this->renderer->plugin('url');
                 $getThisURL = $urlHelper(
                     'record-getthis',
                     ['id' => $record[0]['id'] ?? null],

Original file line number	Diff line number	Diff line change
`@@ -386,7 +386,6 @@ protected function getItemStatusGroup($record, $callnumberSetting)`
`386`	`386`	`}`
`387`	`387`
`388`	`388`	`if (isset($this->getThis)) {`
`389`		`- $urlHelper = $this->renderer->plugin('url');`
`390`	`389`	`$this->getThis->setItems($record);`
`391`	`390`	`}`
`392`	`391`	`// Build list split out by location:`
`@@ -407,6 +406,7 @@ protected function getItemStatusGroup($record, $callnumberSetting)`
`407`	`406`	`) {`
`408`	`407`	`$itemIdParams = !empty($locationStatus['item_id'])`
`409`	`408`	`? ['query' => ['item_id' => $locationStatus['item_id']]] : null;`
	`409`	`+ $urlHelper ??= $this->renderer->plugin('url');`
`410`	`410`	`$getThisURL = $urlHelper(`
`411`	`411`	`'record-getthis',`
`412`	`412`	`['id' => $record[0]['id'] ?? null],`