Fix pipelines

Author: rominail

module/VuFind/src/VuFind/GetThis/GetThisLoader.php

@@ -358,7 +358,7 @@ public function getLocationCode(?string $itemId = null): string
      */
     public function getLink(?string $itemId = null): array|string
     {
-        $isProvidedItemIdNull = is_null($itemId);
+        $isProvidedItemIdNull = null === $itemId;
         // If $itemId is null, call getItem just in case $items returns the items in a different order
         // than the real time holdings information
         $itemId = $this->getItem($itemId)['item_id'] ?? null;
@@ -372,7 +372,7 @@ public function getLink(?string $itemId = null): array|string
             if (!isset($location['items'])) {
                 continue;
             }
-            foreach ((array) $location['items'] as $item) {
+            foreach ((array)$location['items'] as $item) {
                 if (empty($item['link'])) {
                     continue;
                 }

module/VuFind/src/VuFindTest/Integration/MinkTestCase.php

@@ -34,7 +34,6 @@
 use Behat\Mink\Element\Element;
 use Behat\Mink\Element\NodeElement;
 use DMore\ChromeDriver\ChromeDriver;
-use League\CommonMark\Node\Query\OrExpr;
 use ReflectionException;
 use Symfony\Component\Yaml\Yaml;
 use VuFind\Config\PathResolver;

module/VuFind/tests/integration-tests/src/VuFindTest/Mink/GetThisTest.php

@@ -34,6 +34,8 @@
 use Exception;
 use PHPUnit\Framework\Attributes\DataProvider;
 
+use function count;
+
 /**
  * Test class for the GetThis functionality.
  *
@@ -138,7 +140,7 @@ public static function getRecordItems(string $recordId, string ...$callNumbers):
         foreach ($callNumbers as $callNumber) {
             $items[] = [
                 'id' => $recordId,
-                ...$availableItems[$callNumber]
+                ...$availableItems[$callNumber],
             ];
         }
         return $items;
@@ -192,7 +194,7 @@ public static function provideStandardStatusTestData(): array
                         'CallNumberOne',
                         'CallNumberTwo',
                         'CallNumberThree',
-                        'CallNumberFour'
+                        'CallNumberFour',
                     ]
                 ),
                 // $expectedPresence
@@ -279,7 +281,7 @@ public static function provideFullStatusTestData(): array
                         'CallNumberOne',
                         'CallNumberTwo',
                         'CallNumberThree',
-                        'CallNumberFour'
+                        'CallNumberFour',
                     ]
                 ),
                 // $expectedBlockPresence

module/VuFind/tests/unit-tests/src/VuFindTest/GetThisLoaderTest.php

@@ -92,7 +92,7 @@ public function setUp(): void
         $regexConfig = $this->yamlReader->get('Regex.yaml');
         $regexConfig['LOCATION_EXCLUSIVE'][] = '/OUR CAMPUS/i';
         $translator = $this->createMock(Translate::class);
-        $translator->expects($this->any())->method('translate')->willReturnCallback(fn($p) => $p);
+        $translator->expects($this->any())->method('translate')->willReturnCallback(fn ($p) => $p);
         $this->getThis = new GetThisLoader(
             $this->config,
             new Regex($regexConfig),
@@ -112,7 +112,7 @@ public function setGetThisConfig(array $config): void
         try {
             $this->setProperty($this->getThis, 'config', $config);
         } catch (ReflectionException $e) {
-            die("Reflection exception when trying to set the config: " . $e->getMessage());
+            die('Reflection exception when trying to set the config: ' . $e->getMessage());
         }
     }
 
@@ -126,7 +126,7 @@ public function getMockRecordDriver(): SolrDefault|MockObject
         try {
             return $this->createMock(SolrDefault::class);
         } catch (\PHPUnit\Framework\MockObject\Exception $e) {
-            die("An exception has occurred while creating a mock for the record driver: " . $e->getMessage());
+            die('An exception has occurred while creating a mock for the record driver: ' . $e->getMessage());
         }
     }
 
@@ -624,7 +624,7 @@ public function testGetLink()
                             ],
                         ],
                     ],
-                ]
+                ],
             ]);
         $this->setProperty($this->getThis, 'record', $driver);
         $this->assertEquals('https://what_a_great_link.com', $this->getThis->getLink());
@@ -931,7 +931,7 @@ public function testFactory()
         $regex = $this->createMock(Regex::class);
 
         $translator = $this->createMock(Translate::class);
-        $translator->expects($this->any())->method('translate')->willReturnCallback(fn($p) => $p);
+        $translator->expects($this->any())->method('translate')->willReturnCallback(fn ($p) => $p);
 
         $viewHelperManager = $this->createMock(HelperPluginManager::class);
         $viewHelperManager->expects($this->once())->method('get')->willReturn($translator);