Ranking command tweaks

Author: LoneWolfHT

mods/ctf/ctf_modebase/ranking_commands.lua

@@ -257,7 +257,7 @@ minetest.register_chatcommand("top50", {
 })
 
 minetest.register_chatcommand("make_pro", {
-	description = "Make yourself or another player a pro",
+	description = "Make yourself or another player a pro (Will break target player's ranks)",
 	params = "[mode:technical modename] <playername>",
 	privs = {ctf_admin = true},
 	func = function(name, param)
@@ -271,16 +271,17 @@ minetest.register_chatcommand("make_pro", {
 		end
 
 		local old_ranks = mode_data.rankings:get(pname)
+		local note = ""
 		if not old_ranks then
-			return false, string.format("Player '%s' has no rankings!", pname)
+			note = string.format(" Note: Player '%s' had no rankings before that.", pname)
 		end
 
-		mode_data.rankings:add(pname, {score = 8000, kills = 7, deaths = 5, flag_captures = 5})
+		mode_data.rankings:set(pname, {score = 8000, kills = 7, deaths = 5, flag_captures = 5})
 
 		minetest.log("action", string.format(
 			"[ctf_admin] %s made player '%s' a pro in mode %s: %s", name, pname, mode_name, dump(old_ranks)
 		))
-		return true, string.format("Player '%s' is now a pro!", pname)
+		return true, string.format("Player '%s' is now a pro.%s", pname, note)
 	end
 })
 
@@ -306,17 +307,17 @@ minetest.register_chatcommand("add_score", {
 		end
 
 		local old_ranks = mode_data.rankings:get(pname)
+		local note = ""
 		if not old_ranks then
-			return false, string.format("Player '%s' has no rankings!", pname)
+			note = string.format(" Note: Player '%s' had no rankings before that.", pname)
 		end
 
-		local old_score = old_ranks.score or 0
-		mode_data.rankings:set(pname, {score = old_score + score})
+		mode_data.rankings:add(pname, {score = score})
 
 		minetest.log("action", string.format(
 			"[ctf_admin] %s added %s score to player '%s' in mode %s", name, score, pname, mode_name
 		))
-		return true, string.format("Added %s score to player '%s'", score, pname)
+		return true, string.format("Added %s score to player '%s'.%s", score, pname, note)
 	end
 })
 
@@ -353,29 +354,30 @@ minetest.register_chatcommand("transfer_rankings", {
 			end
 		end
 
+		local note = ""
 		if not src_exists then
 			return false, string.format("Source player '%s' has no rankings!", src)
 		end
 		if not dst_exists then
-			return false, string.format("Destination player '%s' has no rankings!", dst)
+			note = string.format(" Note: Destination player '%s' had no rankings.", dst)
 		end
 
 		if src == dst then
 			return false, "Source name and destination name cannot be the same!"
 		end
 
 		for mode_name, mode in pairs(ctf_modebase.modes) do
-			mode.rankings:add(dst, src_rankings[mode_name])
+			mode.rankings:set(dst, src_rankings[mode_name], true)
 		end
 
 		for _, mode in pairs(ctf_modebase.modes) do
 			mode.rankings:set(src, {}, true)
 		end
 
 		minetest.log("action", string.format(
-			"[ctf_admin] %s transferred rankings from '%s' to '%s': %s -> %s",
-			name, src, dst, dump(src_rankings), dump(dst_rankings)
+			"[ctf_admin] %s transferred rankings from '%s' to '%s': %s -> %s | %s",
+			name, src, dst, dump(src_rankings), dump(dst_rankings), note
 		))
-		return true, string.format("Rankings of '%s' have been transferred to '%s'", src, dst)
+		return true, string.format("Rankings of '%s' have been transferred to '%s'.%s", src, dst, note)
 	end
 })