Ensure consistency and follow db constraints while importing new data. (#2390)

When switching a parent value to a value not displaying child, it now reinit the
child to their initial value.
For example, if a record in db has entree_plain_pied=False,
entree_ascenceur=True, if we import a line saying entree_plain_pied=True, then
we now switch to entree_ascenceur=None

Author: mlvernay

erp/imports/serializers.py

@@ -8,6 +8,7 @@
 from erp.imports.utils import get_address_query_to_geocode
 from erp.models import Accessibilite, Activite, Commune, Erp, ExternalSource
 from erp.provider import geocoder, sirene
+from erp.schema import FIELDS
 
 TRUE_VALUES = ["true", "True", "TRUE", "1", "vrai", "Vrai", "VRAI", "oui", "Oui", "OUI", True]
 FALSE_VALUES = ["false", "False", "FALSE", "0", "faux", "Faux", "FAUX", "non", "Non", "NON", False]
@@ -211,6 +212,25 @@ def validate_accessibilite(self, obj):
 
         return obj
 
+    def _handle_children_reinit(self, accessibilite_instance, field_name):
+        field_config = FIELDS.get(field_name)
+        if not field_config or not field_config.get("children"):
+            return
+
+        current_value = getattr(accessibilite_instance, field_name)
+        trigger_values = field_config.get("value_to_display_children", [])
+
+        if str(current_value) not in trigger_values:
+            for child_name in field_config.get("children"):
+                field_obj = accessibilite_instance._meta.get_field(child_name)
+                default_value = field_obj.get_default()
+                if callable(default_value):
+                    default_value = default_value()
+
+                setattr(accessibilite_instance, child_name, default_value)
+
+                self._handle_children_reinit(accessibilite_instance, child_name)
+
     def validate(self, obj):
         if "accessibilite" not in obj:
             raise serializers.ValidationError("Veuillez fournir les données d'accessibilité.")
@@ -307,8 +327,10 @@ def update(self, instance, validated_data, partial=True):
             if enrich_only and getattr(accessibilite, attr, None) is not None:
                 continue
 
-            if validated_data["accessibilite"][attr] not in (None, [], ()):
-                setattr(accessibilite, attr, validated_data["accessibilite"][attr])
+            new_value = validated_data["accessibilite"][attr]
+            if new_value not in (None, [], ()):
+                setattr(accessibilite, attr, new_value)
+                self._handle_children_reinit(accessibilite, attr)
 
         accessibilite.save()
 

tests/erp/imports/test_serializers.py

@@ -134,6 +134,51 @@ def test_erp_update_serializer():
     assert erp.accessibilite.accueil_audiodescription == ["avec_app"]
 
 
+@pytest.mark.django_db
+def test_erp_update_serializer_inconsistencies():
+    erp = ErpFactory(
+        nom="Initial name",
+        accessibilite__accueil_audiodescription_presence=True,
+        accessibilite__accueil_audiodescription=["avec_app"],
+        accessibilite__entree_plain_pied=False,
+        accessibilite__entree_ascenseur=True,
+        accessibilite__entree_ascenseur_pmr=True,
+        accessibilite__accueil_chambre_nombre_accessibles=1,
+        accessibilite__accueil_chambre_douche_siege=True,
+        accessibilite__accueil_cheminement_plain_pied=False,  # control
+        accessibilite__accueil_cheminement_ascenseur=True,  # control
+        accessibilite__accueil_cheminement_ascenseur_pmr=True,  # control
+    )
+
+    serializer = ErpImportSerializer(
+        instance=erp,
+        data={
+            "accessibilite": {
+                "accueil_audiodescription_presence": False,
+                "entree_plain_pied": True,
+                "accueil_chambre_nombre_accessibles": 0,
+            },
+            "nom": "Aux bons pains",
+        },
+        partial=True,
+    )
+    assert serializer.is_valid(), serializer.errors
+    serializer.save()
+
+    erp.refresh_from_db()
+    assert erp.nom != "Aux bons pains", "Name should not be editable"
+    assert erp.accessibilite.accueil_audiodescription_presence is False
+    assert erp.accessibilite.accueil_audiodescription == [], "should have reinit child of attr switched to False"
+    assert erp.accessibilite.entree_plain_pied is True
+    assert erp.accessibilite.entree_ascenseur is None, "should have reinit child"
+    assert erp.accessibilite.entree_ascenseur_pmr is None, "should have reinit child of child"
+    assert erp.accessibilite.accueil_chambre_nombre_accessibles == 0
+    assert erp.accessibilite.accueil_chambre_douche_siege is None, "should have reinit child of attr switched to 0"
+    assert erp.accessibilite.accueil_cheminement_plain_pied is False, "control, should not be reinit"
+    assert erp.accessibilite.accueil_cheminement_ascenseur is True, "control, should not be reinit"
+    assert erp.accessibilite.accueil_cheminement_ascenseur_pmr is True, "control, should not be reinit"
+
+
 @pytest.mark.django_db
 def test_erp_duplicate():
     boulangerie = ActiviteFactory(nom="Boulangerie")