V2

Author: mlvernay

erp/management/commands/api_entreprises_clean_closed.py

@@ -66,7 +66,9 @@ def handle(self, *args, **options):
             query = f"{erp.numero} {erp.voie}" if erp.numero else erp.lieu_dit
             query = f"{erp.nom}, {query} {erp.code_postal} {erp.commune}"
 
-            if check_closed(query, erp.commune_ext.code_insee):
+            query_address = f"{erp.numero} {erp.voie}" if erp.numero else erp.lieu_dit
+            query_address = f"{query_address} {erp.code_postal} {erp.commune}"
+            if check_closed(erp.nom, query_address, erp.commune_ext.code_insee):
                 self._flag_erp_as_closed(erp)
                 continue
 

erp/provider/entreprise.py

@@ -125,23 +125,36 @@ def search(terms, code_insee, activities):
         raise RuntimeError(f"entreprise api error: {err}")
 
 
-def check_closed(term, code_insee):
+def check_closed(name, address, code_insee):
+    term = f"{name}, {address}"
     payload = {
         "per_page": MAX_PER_PAGE,
         "page": 1,
         "q": term,
         "code_insee": code_insee,
         "categorie_entreprise": "PME,ETI",
     }
-    res = requests.get(
-        f"{BASE_URL_ENTERPRISE_API}",
-        payload,
-        timeout=5,
-    )
+    res = requests.get(f"{BASE_URL_ENTERPRISE_API}", payload, timeout=5)
     try:
         if not (len(results := (res.json().get("results") or [])) == 1):
             return False
     except (requests.exceptions.JSONDecodeError, requests.exceptions.ReadTimeout):
         return False
 
-    return results[0].get("siege", {}).get("date_fermeture") is not None
+    closed = results[0].get("siege", {}).get("date_fermeture") is not None
+    if not closed:
+        return False
+
+    # Do the same request without the erp name parameter nor the code_insee to obtain other ERPs at the same address.
+    # If we have more than one result, we can't consider the ERP as closed.
+    payload["q"] = address
+    del payload["code_insee"]
+
+    res = requests.get(f"{BASE_URL_ENTERPRISE_API}", payload, timeout=5)
+    try:
+        if len(res.json().get("results") or []) > 1:
+            return False
+    except (requests.exceptions.JSONDecodeError, requests.exceptions.ReadTimeout):
+        return False
+
+    return True