Skip to content

Commit adaeaac

Browse files
committed
Use tensorflow bottles for building MacOS wheels
Building from source takes too much time, therefore reverted changes in previous comments.
1 parent 67528a5 commit adaeaac

1 file changed

Lines changed: 20 additions & 14 deletions

File tree

pyproject-tensorflow.toml

Lines changed: 20 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,16 @@ before-build = [
3232
"brew install chromaprint",
3333
"brew link --overwrite ffmpeg@2.8",
3434
# Delocate checks for the min OS version (LC_BUILD_VERSION or C_VERSION_MIN_MACOSX).
35-
# Tensorflow bottle a has minimum target of 14.2 which is too new, therefore, building from source.
36-
# Workaroud to SDK not being found: https://github.com/actions/runner-images/issues/9811
37-
#"sudo xcode-select -s /Library/Developer/CommandLineTools",
38-
"echo Checking available SDKs:",
39-
"xcodebuild -showsdks",
40-
"SDKROOT=$(xcrun --sdk macosx13.0 --show-sdk-path) brew install --build-from-source tensorflow",
41-
#"brew tap MTG/essentia",
42-
#"brew install gaia --HEAD",
35+
# Tensorflow bottle a has minimum target of 14.2 which is too new.
36+
# We could build from source as a workaround, however, it takes too much time on the CI worker.
37+
# To keep it simple, just use the bottles available for tensorflow.
38+
"brew install tensorflow",
39+
# ---
40+
# Building tensorflow from source:
41+
#"echo Checking available SDKs:",
42+
#"xcodebuild -showsdks",
43+
#"SDKROOT=$(xcrun --sdk macosx13.0 --show-sdk-path) brew install --build-from-source tensorflow",
44+
# ---
4345
# Override VIRTUAL_ENV set by cibuildwheel to ensure global install
4446
"VIRTUAL_ENV=/usr/local python waf configure --with-tensorflow --pkg-config-path=\"${PKG_CONFIG_PATH}\"",
4547
"python waf",
@@ -63,12 +65,16 @@ before-build = [
6365
"brew install chromaprint",
6466
"brew link --overwrite ffmpeg@2.8",
6567
# Delocate checks for the min OS version (LC_BUILD_VERSION or C_VERSION_MIN_MACOSX).
66-
# Tensorflow bottle has a minumum target of 15.2, which is too new, therefore, building from source.
67-
# Workaroud to SDK not being found: https://github.com/actions/runner-images/issues/9811
68-
#"sudo xcode-select -s /Library/Developer/CommandLineTools",
69-
"echo Checking available SDKs:",
70-
"xcodebuild -showsdks",
71-
"SDKROOT=$(xcrun --sdk macosx14.0 --show-sdk-path) brew install --build-from-source tensorflow",
68+
# Tensorflow bottle a has minimum target of 15.2 which is too new.
69+
# We could build from source as a workaround, however, it takes too much time on the CI worker.
70+
# To keep it simple, just use the bottles available for tensorflow.
71+
"brew install tensorflow",
72+
# ---
73+
# Building tensorflow from source:
74+
#"echo Checking available SDKs:",
75+
#"xcodebuild -showsdks",
76+
#"SDKROOT=$(xcrun --sdk macosx14.0 --show-sdk-path) brew install --build-from-source tensorflow",
77+
# ---
7278
# Override VIRTUAL_ENV set by cibuildwheel to ensure global install
7379
"VIRTUAL_ENV=/usr/local python waf configure --with-tensorflow --pkg-config-path=\"${PKG_CONFIG_PATH}\" --arch arm64 --no-msse",
7480
"python waf",

0 commit comments

Comments
 (0)