Skip to content

Wrong documenation of log compression in TriangularBands and related algorithms #734

Open
@dbogdanov

Description

@dbogdanov

The documentation error originates in updates to TriangularBands algorithm introduced in 4c8f489 (#227), which changed the compression from log10 to log2, but the documentation wasn't updated accordingly. It was later propagated to other algorithms based on or reusing code from TriangularBands: TriangularBarkBands (9de18e6), MelBands (5d1e8bc), SpectrumToCent.

In all these algorithm the actual log compression is log2(1+x) instead of log10(1+x).

The MFCC and BFCC algorithms aren't affected as they work with raw energy values output by MelBands and apply their own log normalization for the computation of cepstrum coefficients.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions