avoid rebuilding qtkeychain on each build - #512
Merged
Conversation
Reviewer's GuideAdjusts the qtkeychain ExternalProject integration in CMake so that previously built artifacts are reused instead of rebuilding qtkeychain on every configure/build, while centralizing binary/include path handling and preserving Windows deployment logic. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Changing
ALWAYS 0toBUILD_ALWAYS 0inExternalProject_Addmay not be a recognized option forExternalProjectin some CMake versions; double‑check the correct keyword (likelyALWAYS) to avoid silently breaking the rebuild behavior. - When
QTKEYCHAIN_SHARED_LIBRARYalready exists, the Windows‑only copy step (qtkeychain_copy/ DLL deployment) is skipped in the new flow; consider wiring the deploy/copy logic to run in the 'already built' path as well so the runtime output directory stays in sync. - The assignments of
QTKEYCHAIN_INCLUDE_DIRandQTKEYCHAIN_LIBRARY_DIRare duplicated (once before theif(EXISTS ...)and again at the end); you can remove the redundancy to keep the CMake logic simpler and less error‑prone.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Changing `ALWAYS 0` to `BUILD_ALWAYS 0` in `ExternalProject_Add` may not be a recognized option for `ExternalProject` in some CMake versions; double‑check the correct keyword (likely `ALWAYS`) to avoid silently breaking the rebuild behavior.
- When `QTKEYCHAIN_SHARED_LIBRARY` already exists, the Windows‑only copy step (`qtkeychain_copy` / DLL deployment) is skipped in the new flow; consider wiring the deploy/copy logic to run in the 'already built' path as well so the runtime output directory stays in sync.
- The assignments of `QTKEYCHAIN_INCLUDE_DIR` and `QTKEYCHAIN_LIBRARY_DIR` are duplicated (once before the `if(EXISTS ...)` and again at the end); you can remove the redundancy to keep the CMake logic simpler and less error‑prone.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #512 +/- ##
==========================================
- Coverage 25.21% 25.21% -0.01%
==========================================
Files 512 512
Lines 42367 42367
Branches 4577 4579 +2
==========================================
- Hits 10683 10681 -2
- Misses 31684 31686 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Avoid rebuilding the bundled QtKeychain external project when its compiled artifacts already exist and expose consistent include and library paths from the build directory.
Enhancements: