Skip to content

Commit 2b0a8c8

Browse files
authored
Merge pull request #133 from MaanasArora/bug/allowed-origins-settings
refactor: update CORS middleware to use client_origin from settings
2 parents 8e02d8c + da91af3 commit 2b0a8c8

2 files changed

Lines changed: 4 additions & 5 deletions

File tree

server/convergent/main.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,13 @@
88

99
app = FastAPI()
1010

11-
print(settings.allowed_origins)
11+
allowed_origins = [settings.client_origin]
12+
13+
print("Allowed origins:", allowed_origins)
1214

1315
app.add_middleware(
1416
CORSMiddleware,
15-
allow_origins=settings.allowed_origins,
17+
allow_origins=allowed_origins,
1618
allow_credentials=True,
1719
allow_methods=["GET", "POST", "PUT", "DELETE", "OPTIONS"],
1820
)

server/convergent/settings.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,7 @@
55

66
class Settings(BaseSettings):
77
database_url: str = "sqlite:///convergent.db"
8-
98
client_origin: str = "http://localhost:5173"
10-
allowed_origins: list[str] = [client_origin]
11-
129
secret_key: str
1310
algorithm: str = "HS256"
1411
expires_delta_seconds: int = 3600

0 commit comments

Comments
 (0)