added comments in halfshuffle to highlitght issues

AngeloElSaliby · AngeloElSaliby · commit 991b0e008af4 · 2025-04-15T21:44:28.000+02:00
diff --git a/PathSignatures.m2 b/PathSignatures.m2
@@ -831,13 +831,16 @@ halfshuffleHelper(NCRingElement, List) := (f,w) -> (
 )
 halfshuffle = method();
 halfshuffle (NCRingElement, NCRingElement) := (f,g) -> (
+    --Exlclude one input is 0
+    --fix behaviour for constants
     if(ring f === ring g) then (
         return(linExt(i->halfshuffleHelper(f,i),g));)
     else (
         error "Can not apply halfshuffle to polynomials from different rings";
     )
 )
 
+--The notation in the reference is the other way around but for some reason changing this to >> breaks the code
 NCRingElement << NCRingElement := (f,g) -> (
     halfshuffle(f,g)
 )

Original file line number	Diff line number	Diff line change
`@@ -831,13 +831,16 @@ halfshuffleHelper(NCRingElement, List) := (f,w) -> (`
`831`	`831`	`)`
`832`	`832`	`halfshuffle = method();`
`833`	`833`	`halfshuffle (NCRingElement, NCRingElement) := (f,g) -> (`
	`834`	`+ --Exlclude one input is 0`
	`835`	`+ --fix behaviour for constants`
`834`	`836`	`if(ring f === ring g) then (`
`835`	`837`	`return(linExt(i->halfshuffleHelper(f,i),g));)`
`836`	`838`	`else (`
`837`	`839`	`error "Can not apply halfshuffle to polynomials from different rings";`
`838`	`840`	`)`
`839`	`841`	`)`
`840`	`842`
	`843`	`+--The notation in the reference is the other way around but for some reason changing this to >> breaks the code`
`841`	`844`	`NCRingElement << NCRingElement := (f,g) -> (`
`842`	`845`	`halfshuffle(f,g)`
`843`	`846`	`)`