Merge pull request #594 from MadridSquad/hot-fix/error-library-guest

fix: loading only as a guest

Author: ahmedhgabr

presentation/src/main/java/com/madrid/presentation/component/header/MovieDetailsHeader.kt

@@ -51,26 +51,32 @@ fun MovieDetailsHeader(
             modifier = Modifier.padding(vertical = 4.dp)
         ) {
             rate?.let {
-                DetailsChips(
-                    icon = painterResource(com.madrid.designSystem.R.drawable.bold_star),
-                    iconTint = Theme.color.system.warning,
-                    text = it,
-                )
+                if (it.isNotEmpty()) {
+                    DetailsChips(
+                        icon = painterResource(com.madrid.designSystem.R.drawable.bold_star),
+                        iconTint = Theme.color.system.warning,
+                        text = rate,
+                    )
+                }
             }
 
             time?.let {
+                if (it.isNotEmpty()) {
+                    DetailsChips(
+                        icon = painterResource(com.madrid.designSystem.R.drawable.outline_clock_circle),
+                        iconTint = Theme.color.surfaces.onSurfaceVariant,
+                        text = time,
+                    )
+                }
+            }
+
+            if (date.isNotEmpty()) {
                 DetailsChips(
-                    icon = painterResource(com.madrid.designSystem.R.drawable.outline_clock_circle),
+                    icon = painterResource(com.madrid.designSystem.R.drawable.outline_calendar),
                     iconTint = Theme.color.surfaces.onSurfaceVariant,
-                    text = it,
+                    text = date,
                 )
             }
-
-            DetailsChips(
-                icon = painterResource(com.madrid.designSystem.R.drawable.outline_calendar),
-                iconTint = Theme.color.surfaces.onSurfaceVariant,
-                text = date,
-            )
         }
     }
 }

presentation/src/main/java/com/madrid/presentation/screens/libraryScreen/LibraryScreen.kt

@@ -121,11 +121,13 @@ private fun LibraryScreenContent(
         enter = fadeIn(),
         exit = fadeOut()
     ) {
-        LibraryColumn(state, libraryInteractionListener)
+        if (state.isGuest.not()) {
+            LibraryColumn(state, libraryInteractionListener)
+        }
     }
 
     AnimatedVisibility(
-        visible = state.errorMessage.isNullOrBlank().not(),
+        visible = state.errorMessage.isNullOrBlank().not() && state.isGuest.not(),
         enter = fadeIn(),
         exit = fadeOut()
     ) {

presentation/src/main/java/com/madrid/presentation/viewModel/libraryViewModel/LibraryViewModel.kt

@@ -28,13 +28,14 @@ class LibraryViewModel @Inject constructor(
 ), LibraryInteractionListener {
 
     fun loadData() {
+        getIsGuest()
         getWatchList()
         getFavoriteList()
         getHistoryList()
-        getIsGuest()
     }
 
     fun onRefresh() {
+        getIsGuest()
         getWatchList()
         getFavoriteList()
         getHistoryList()
@@ -84,7 +85,6 @@ class LibraryViewModel @Inject constructor(
     fun getIsGuest() {
         updateState {
             it.copy(
-                isLoading = true,
                 errorMessage = null
             )
         }
@@ -94,7 +94,7 @@ class LibraryViewModel @Inject constructor(
             },
             onNewValue = { isGuest ->
                 updateState {
-                    it.copy(isGuest = isGuest, isLoading = false)
+                    it.copy(isGuest = isGuest, isLoading = false , errorMessage = null)
                 }
             },
             onError = { throwable -> onError(message = throwable.message) }
@@ -111,7 +111,8 @@ class LibraryViewModel @Inject constructor(
                 updateState {
                     it.copy(
                         isWatchListLoading = false,
-                        watchList = watchList.map { it.toWatchListUiState() }
+                        watchList = watchList.map { it.toWatchListUiState() },
+                        errorMessage = null
                     )
                 }
             },
@@ -129,7 +130,8 @@ class LibraryViewModel @Inject constructor(
                 updateState {
                     it.copy(
                         isFavouriteLoading = false,
-                        favoriteList = favoriteList.map { it.toMediaUiState() }
+                        favoriteList = favoriteList.map { it.toMediaUiState() },
+                        errorMessage = null
                     )
                 }
             },
@@ -153,7 +155,8 @@ class LibraryViewModel @Inject constructor(
                 updateState {
                     it.copy(
                         isHistoryLoading = false,
-                        historyList = historyList
+                        historyList = historyList,
+                        errorMessage = null
                     )
                 }
             },

presentation/src/main/java/com/madrid/presentation/viewModel/shared/parser/formatDateKotlinx.kt

@@ -5,11 +5,16 @@ import kotlinx.datetime.toLocalDate
 
 
 fun formatDateKotlinx(dateString: String): String {
-    val date: LocalDate = dateString.toLocalDate()
+    try{
+        val date: LocalDate = dateString.toLocalDate()
 
-    val month = date.monthNumber.toString().padStart(2, '0')
-    val day = date.dayOfMonth.toString().padStart(2, '0')
-    val year = date.year.toString()
+        val month = date.monthNumber.toString().padStart(2, '0')
+        val day = date.dayOfMonth.toString().padStart(2, '0')
+        val year = date.year.toString()
 
-    return "$month/$day/$year"
+        return "$month/$day/$year"
+    }
+    catch (e: Exception) {
+        return ""
+    }
 }