Replace forward declaration to find bug with segfault

Author: MahBoiDeveloper

src/Convert.hpp

@@ -9,7 +9,7 @@ namespace Convert
     /// @brief Returns list QStringList of QString as element by converting std::list<std::string>value.
     QStringList ToQStringList(const std::list<std::string>& srcList);
     /// @brief Returns list std::list of std::string as element by converting QStringList<QString> value.
-    inline std::list<std::string> ToStdStringList(const QStringList&            srcList);
+    inline std::list<std::string> ToStdStringList(const QStringList& srcList);
     /// @brief Return enum Languages value that equivalent to the text value.
     Languages ToLangEnum(const std::string& locale);
     /// @brief Converts QChar to Qt::Key enum equivalent.

src/GUI/HotkeysMainWindow.cpp

@@ -4,10 +4,7 @@
 #include <QCoreApplication>
 #include <QDialog>
 #include <QDialogButtonBox>
-#include <QButtonGroup>
 #include <QVBoxLayout>
-#include <QTreeWidgetItem>
-#include <QScrollArea>
 #include <QComboBox>
 
 #include "../Parsers/CSFParser.hpp"
@@ -16,10 +13,9 @@
 #include "../Unsorted.hpp"
 #include "../Convert.hpp"
 
-#include "ActionHotkeyWidget.hpp"
 #include "ImageManager.hpp"
-#include "HotkeysMainWindow.hpp"
 #include "WindowManager.hpp"
+#include "HotkeysMainWindow.hpp"
 
 HotkeysMainWindow::HotkeysMainWindow(const QVariant& configuration, QWidget* parent)
     : QMainWindow(parent)

src/GUI/HotkeysMainWindow.hpp

@@ -1,15 +1,14 @@
 #pragma once
 #include <QMainWindow>
+#include <QScrollArea>
+#include <QTreeWidgetItem>
+#include <QButtonGroup>
+#include <QHBoxLayout>
+
 #include "../Parsers/JSONFile.hpp"
+#include "ActionHotkeyWidget.hpp"
 #include "Faction.hpp"
 
-class QScrollArea;
-class QTreeWidget;
-class QButtonGroup;
-class QHBoxLayout;
-
-class ActionHotkeyWidget;
-
 class HotkeysMainWindow final : public QMainWindow
 {
     Q_OBJECT

src/GUI/ImageManager.cpp

@@ -1,7 +1,6 @@
 #include <QDir>
 #include <QImage>
 #include <QPixmap>
-#include <QFileInfo>
 
 #include "../../libwebp/src/webp/decode.h"
 #include "../Logger.hpp"

src/GUI/ImageManager.hpp

@@ -1,8 +1,7 @@
 #pragma once
+#include <QFileInfo>
 #include "../ProgramConstants.hpp"
 
-class QFileInfo;
-
 class ImageManager
 {
 private: // Data

src/GUI/Translations/ru.ts

@@ -126,113 +126,113 @@
 <context>
     <name>HotkeysMainWindow</name>
     <message>
-        <location filename="../HotkeysMainWindow.cpp" line="166"/>
+        <location filename="../HotkeysMainWindow.cpp" line="162"/>
         <source>File</source>
         <translation>Файл</translation>
     </message>
     <message>
-        <location filename="../HotkeysMainWindow.cpp" line="167"/>
+        <location filename="../HotkeysMainWindow.cpp" line="163"/>
         <source>Open</source>
         <translation>Открыть</translation>
     </message>
     <message>
-        <location filename="../HotkeysMainWindow.cpp" line="168"/>
+        <location filename="../HotkeysMainWindow.cpp" line="164"/>
         <source>Save</source>
         <translation>Сохранить</translation>
     </message>
     <message>
-        <location filename="../HotkeysMainWindow.cpp" line="169"/>
+        <location filename="../HotkeysMainWindow.cpp" line="165"/>
         <source>Save As...</source>
         <translation>Сохранить как...</translation>
     </message>
     <message>
-        <location filename="../HotkeysMainWindow.cpp" line="170"/>
+        <location filename="../HotkeysMainWindow.cpp" line="166"/>
         <source>Special</source>
         <translation>Дополнительно</translation>
     </message>
     <message>
-        <location filename="../HotkeysMainWindow.cpp" line="179"/>
+        <location filename="../HotkeysMainWindow.cpp" line="175"/>
         <source>View</source>
         <translation>Вид</translation>
     </message>
     <message>
-        <location filename="../HotkeysMainWindow.cpp" line="180"/>
+        <location filename="../HotkeysMainWindow.cpp" line="176"/>
         <source>Status Bar</source>
         <translation>Строка состояния</translation>
     </message>
     <message>
-        <location filename="../HotkeysMainWindow.cpp" line="181"/>
+        <location filename="../HotkeysMainWindow.cpp" line="177"/>
         <source>Enable</source>
         <translation>Включить</translation>
     </message>
     <message>
-        <location filename="../HotkeysMainWindow.cpp" line="182"/>
+        <location filename="../HotkeysMainWindow.cpp" line="178"/>
         <source>Disable</source>
         <translation>Отключить</translation>
     </message>
     <message>
-        <location filename="../HotkeysMainWindow.cpp" line="186"/>
+        <location filename="../HotkeysMainWindow.cpp" line="182"/>
         <source>Settings</source>
         <translation>Настройки</translation>
     </message>
     <message>
-        <location filename="../HotkeysMainWindow.cpp" line="189"/>
+        <location filename="../HotkeysMainWindow.cpp" line="185"/>
         <source>Language</source>
         <translation>Язык</translation>
     </message>
     <message>
-        <location filename="../HotkeysMainWindow.cpp" line="193"/>
-        <location filename="../HotkeysMainWindow.cpp" line="471"/>
+        <location filename="../HotkeysMainWindow.cpp" line="189"/>
+        <location filename="../HotkeysMainWindow.cpp" line="467"/>
         <source>About</source>
         <translation>О программе</translation>
     </message>
     <message>
-        <location filename="../HotkeysMainWindow.cpp" line="324"/>
+        <location filename="../HotkeysMainWindow.cpp" line="320"/>
         <source>Layout %1</source>
         <translation>Раскладка %1</translation>
     </message>
     <message>
-        <location filename="../HotkeysMainWindow.cpp" line="451"/>
+        <location filename="../HotkeysMainWindow.cpp" line="447"/>
         <source>Authors: </source>
         <translation>Авторы: </translation>
     </message>
     <message>
-        <location filename="../HotkeysMainWindow.cpp" line="452"/>
+        <location filename="../HotkeysMainWindow.cpp" line="448"/>
         <source>Version: </source>
         <translation>Версия: </translation>
     </message>
     <message>
-        <location filename="../HotkeysMainWindow.cpp" line="453"/>
+        <location filename="../HotkeysMainWindow.cpp" line="449"/>
         <source>Program licensed with </source>
         <translation>Программа лицензирована под </translation>
     </message>
     <message>
-        <location filename="../HotkeysMainWindow.cpp" line="454"/>
+        <location filename="../HotkeysMainWindow.cpp" line="450"/>
         <source>GitHub repository:</source>
         <translation>Репозиторий на GitHub:</translation>
     </message>
     <message>
-        <location filename="../HotkeysMainWindow.cpp" line="456"/>
+        <location filename="../HotkeysMainWindow.cpp" line="452"/>
         <source>Support development:</source>
         <translation>Поддержать разработку:</translation>
     </message>
     <message>
-        <location filename="../HotkeysMainWindow.cpp" line="505"/>
+        <location filename="../HotkeysMainWindow.cpp" line="501"/>
         <source>Lanugage</source>
         <translation>Язык</translation>
     </message>
     <message>
-        <location filename="../HotkeysMainWindow.cpp" line="514"/>
+        <location filename="../HotkeysMainWindow.cpp" line="510"/>
         <source>LANGUAGE</source>
         <translation>ЯЗЫК</translation>
     </message>
     <message>
-        <location filename="../HotkeysMainWindow.cpp" line="526"/>
+        <location filename="../HotkeysMainWindow.cpp" line="522"/>
         <source>OK</source>
         <translation>Ок</translation>
     </message>
     <message>
-        <location filename="../HotkeysMainWindow.cpp" line="527"/>
+        <location filename="../HotkeysMainWindow.cpp" line="523"/>
         <source>Cancel</source>
         <translation>Отмена</translation>
     </message>

src/GUI/WindowManager.hpp

@@ -1,5 +1,6 @@
 #pragma once
 #include <memory>
+#include <QTranslator>
 
 #include "../ProgramConstants.hpp"
 
@@ -8,8 +9,6 @@
 
 #define WINDOW_MANAGER WindowManager::Instance
 
-class QTranslator;
-
 class WindowManager final
 {
 private: // Data