chore: update to Biome v2 (commaai#611)

Author: incognitojam

biome.jsonc

@@ -1,49 +1,45 @@
 {
-  "$schema": "https://biomejs.dev/schemas/1.9.4/schema.json",
+  "$schema": "https://biomejs.dev/schemas/2.2.3/schema.json",
   "vcs": {
     "enabled": true,
     "clientKind": "git",
     "useIgnoreFile": true
   },
   "files": {
     "ignoreUnknown": false,
-    "ignore": []
+    "includes": ["**"]
   },
   "formatter": {
     "enabled": true,
     "formatWithErrors": true,
     "indentStyle": "space",
+    "lineWidth": 140,
     "useEditorconfig": true
   },
-  "organizeImports": {
-    "enabled": false
-  },
+  "assist": { "actions": { "source": { "organizeImports": "off" } } },
   "linter": {
     "enabled": true,
     "rules": {
       "recommended": true,
-      "a11y": {
-        "all": false
-      },
+      "a11y": "off",
       "complexity": {
         "noForEach": "off"
       },
       "correctness": {
         "noUnusedImports": "error",
-        "noUnusedVariables": "error",
-        // SolidJS does not require JSX key in iterables
-        "useJsxKeyInIterable": "off"
+        "noUnusedVariables": "error"
       },
       "performance": {
         "noBarrelFile": "error"
       },
-      "style": {
-        "all": false
-      },
+      "style": "off",
       "suspicious": {
-        // SolidJS does not use React-style prop names
-        "noReactSpecificProps": "error"
+        // Tailwind makes use of custom at-rules
+        "noUnknownAtRules": "off"
       }
+    },
+    "domains": {
+      "solid": "recommended"
     }
   },
   "javascript": {

bun.lock

@@ -22,6 +22,7 @@
   "packageManager": "bun@1.2.9",
   "type": "module",
   "//devDependencies": {
+    "@biomejs/biome": "code formatter and linter",
     "@solidjs/testing-library": "test solid components (only used for App.jsx component)",
     "@types/mapbox__polyline": "types for mapbox elements",
     "@vite-pwa/assets-generator": "generate PWA assets during build",
@@ -41,7 +42,7 @@
     "wrangler": "used for deploying assets to cloudflare"
   },
   "devDependencies": {
-    "@biomejs/biome": "1.9.4",
+    "@biomejs/biome": "2.2.3",
     "@solidjs/testing-library": "^0.8.10",
     "@tanstack/solid-query-devtools": "^5.72.2",
     "@types/bun": "^1.2.9",
@@ -91,5 +92,11 @@
   "engines": {
     "node": ">=20.11.0"
   },
-  "trustedDependencies": ["@biomejs/biome", "@sentry/cli", "esbuild", "lefthook", "workerd"]
+  "trustedDependencies": [
+    "@biomejs/biome",
+    "@sentry/cli",
+    "esbuild",
+    "lefthook",
+    "workerd"
+  ]
 }

package.json

@@ -1,4 +1,4 @@
-import { AthenaCallResponse, BackendAthenaCallResponse, BackendAthenaCallResponseError } from '~/api/types'
+import type { AthenaCallResponse, BackendAthenaCallResponse, BackendAthenaCallResponseError } from '~/api/types'
 import { fetcher } from '.'
 import { ATHENA_URL } from './config'
 

src/api/athena.ts

@@ -1,4 +1,4 @@
-import {
+import type {
   CancelUploadRequest,
   CancelUploadResponse,
   Files,

src/api/file.ts

@@ -2,8 +2,8 @@ import { createResource, Match, Switch } from 'solid-js'
 import type { JSXElement, VoidComponent } from 'solid-js'
 import clsx from 'clsx'
 
-import { GPSPathPoint, getCoords } from '~/api/derived'
-import { Coords, getPathStaticMapUrl } from '~/map'
+import { type GPSPathPoint, getCoords } from '~/api/derived'
+import { type Coords, getPathStaticMapUrl } from '~/map'
 import { getThemeId } from '~/theme'
 import type { Route } from '~/api/types'
 
@@ -33,11 +33,7 @@ const getStaticMapUrl = (gpsPoints: GPSPathPoint[]): string | undefined => {
   return getPathStaticMapUrl(themeId, path, 512, 512, true)
 }
 
-const State = (props: {
-  children: JSXElement
-  trailing?: JSXElement
-  opaque?: boolean
-}) => {
+const State = (props: { children: JSXElement; trailing?: JSXElement; opaque?: boolean }) => {
   return (
     <div class={clsx('absolute flex size-full items-center justify-center gap-2', props.opaque && 'bg-surface text-on-surface')}>
       <span class="text-xs">{props.children}</span>

src/components/RouteStaticMap.tsx

@@ -1,5 +1,5 @@
 import clsx from 'clsx'
-import { For, Suspense, VoidComponent } from 'solid-js'
+import { For, Suspense, type VoidComponent } from 'solid-js'
 
 const StatisticBar: VoidComponent<{ class?: string; statistics: { label: string; value: () => unknown }[] }> = (props) => {
   return (

src/components/StatisticBar.tsx

@@ -1,12 +1,12 @@
-import { createEffect, createMemo, For, Match, Show, Switch, VoidComponent } from 'solid-js'
+import { createEffect, createMemo, For, Match, Show, Switch, type VoidComponent } from 'solid-js'
 import { queryOptions, useMutation, useQuery, useQueryClient } from '@tanstack/solid-query'
 import { createStore, reconcile } from 'solid-js/store'
 import LinearProgress from './material/LinearProgress'
-import Icon, { IconName } from './material/Icon'
+import Icon, { type IconName } from './material/Icon'
 import IconButton from './material/IconButton'
 import StatisticBar from './StatisticBar'
 import Button from '~/components/material/Button'
-import { AthenaOfflineQueueResponse, UploadFilesToUrlsRequest, UploadQueueItem } from '~/api/types'
+import type { AthenaOfflineQueueResponse, UploadFilesToUrlsRequest, UploadQueueItem } from '~/api/types'
 import { cancelUpload, getUploadQueue } from '~/api/file'
 import { getAthenaOfflineQueue } from '~/api/devices'
 

src/components/UploadQueue.tsx

@@ -2,7 +2,7 @@ import type { JSXElement, ParentComponent } from 'solid-js'
 import { Show, splitProps } from 'solid-js'
 import clsx from 'clsx'
 
-import ButtonBase, { ButtonBaseProps } from './ButtonBase'
+import ButtonBase, { type ButtonBaseProps } from './ButtonBase'
 import Icon from './Icon'
 
 type ButtonProps = ButtonBaseProps & {

src/components/material/Button.tsx

@@ -1,4 +1,4 @@
-import { type VoidComponent } from 'solid-js'
+import type { VoidComponent } from 'solid-js'
 import clsx from 'clsx'
 
 // Specify icon names to load only the necessary icons, reducing font payload.