Skip to content

Commit bbc3cc0

Browse files
authored
fix: add cursor pointer to all button elements (#2009)
1 parent 9365ef2 commit bbc3cc0

File tree

11 files changed

+29
-21
lines changed

11 files changed

+29
-21
lines changed

apps/mail/components/create/create-email.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ export function CreateEmail({
209209
<div className="flex min-h-screen flex-col items-center justify-center gap-1">
210210
<div className="flex w-[750px] justify-start">
211211
<DialogClose asChild className="flex">
212-
<button className="dark:bg-panelDark flex items-center gap-1 rounded-lg bg-[#F0F0F0] px-2 py-1.5">
212+
<button className="dark:bg-panelDark flex items-center gap-1 rounded-lg bg-[#F0F0F0] px-2 py-1.5 cursor-pointer">
213213
<X className="fill-muted-foreground mt-0.5 h-3.5 w-3.5 dark:fill-[#929292]" />
214214
<span className="text-muted-foreground text-sm font-medium dark:text-white">
215215
esc

apps/mail/components/mail/mail-list.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -968,7 +968,7 @@ export const MailList = memo(
968968
<p className="text-lg">It's empty here</p>
969969
<p className="text-md text-muted-foreground dark:text-white/50">
970970
Search for another email or{' '}
971-
<button className="underline" onClick={clearFilters}>
971+
<button type="button" className="underline cursor-pointer" onClick={clearFilters}>
972972
clear filters
973973
</button>
974974
</p>

apps/mail/components/mail/render-labels.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ export const RenderLabels = ({ count = 1, labels }: { count?: number; labels: La
5151
{hiddenLabels.length > 0 && (
5252
<Tooltip>
5353
<TooltipTrigger asChild>
54-
<button className="text-foreground dark:bg-subtleBlack bg-subtleWhite inline-block overflow-hidden truncate rounded px-1.5 py-0.5 text-xs font-medium">
54+
+ <button type="button" className="text-foreground dark:bg-subtleBlack bg-subtleWhite inline-block overflow-hidden truncate rounded px-1.5 py-0.5 text-xs font-medium cursor-pointer">
5555
+{hiddenLabels.length}
5656
</button>
5757
</TooltipTrigger>

apps/mail/components/mail/thread-display.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -873,7 +873,7 @@ export function ThreadDisplay() {
873873

874874
<DropdownMenu>
875875
<DropdownMenuTrigger asChild>
876-
<button className="inline-flex h-7 w-7 items-center justify-center gap-1 overflow-hidden rounded-lg bg-white focus:outline-none focus:ring-0 dark:bg-[#313131]">
876+
<button type="button" aria-label="Thread actions" aria-haspopup="menu" className="inline-flex h-7 w-7 items-center justify-center gap-1 overflow-hidden rounded-lg bg-white cursor-pointer focus:outline-hidden focus:ring-0 dark:bg-[#313131]">
877877
<ThreeDots className="fill-iconLight dark:fill-iconDark" />
878878
</button>
879879
</DropdownMenuTrigger>

apps/mail/components/ui/app-sidebar.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ function ComposeButton() {
200200
<DialogDescription></DialogDescription>
201201

202202
<DialogTrigger asChild>
203-
<button className="relative mb-1.5 inline-flex h-8 w-full items-center justify-center gap-1 self-stretch overflow-hidden rounded-lg border border-gray-200 bg-[#006FFE] text-black dark:border-none dark:text-white">
203+
<button type="button" className="relative mb-1.5 inline-flex h-8 w-full items-center justify-center gap-1 self-stretch overflow-hidden rounded-lg border border-gray-200 bg-[#006FFE] text-black dark:border-none dark:text-white cursor-pointer">
204204
{state === 'collapsed' && !isMobile ? (
205205
<PencilCompose className="mt-0.5 fill-white text-black" />
206206
) : (

apps/mail/components/ui/button.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import * as React from 'react';
55
import { cn } from '@/lib/utils';
66

77
const buttonVariants = cva(
8-
'inline-flex items-center justify-center gap-2 whitespace-nowrap rounded-lg text-sm font-medium ring-offset-background transition-colors focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2 disabled:pointer-events-none disabled:opacity-50 [&_svg]:pointer-events-none [&_svg]:size-4 [&_svg]:shrink-0 aria-busy:cursor-progress cursor-pointer',
8+
'inline-flex items-center justify-center cursor-pointer gap-2 whitespace-nowrap rounded-lg text-sm font-medium ring-offset-background transition-colors focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2 disabled:pointer-events-none disabled:opacity-50 [&_svg]:pointer-events-none [&_svg]:size-4 [&_svg]:shrink-0 aria-busy:cursor-progress',
99
{
1010
variants: {
1111
variant: {

apps/mail/components/ui/sidebar.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -365,7 +365,7 @@ const SidebarMenuItem = React.forwardRef<HTMLLIElement, React.ComponentProps<'li
365365
SidebarMenuItem.displayName = 'SidebarMenuItem';
366366

367367
const sidebarMenuButtonVariants = cva(
368-
'peer/menu-button flex w-full items-center gap-2 overflow-hidden rounded-lg p-2 text-left text-sm outline-none ring-sidebar-ring transition-[width,height,padding] hover:bg-sidebar-accent hover:text-sidebar-accent-foreground focus-visible:ring-2 active:bg-sidebar-accent active:text-sidebar-accent-foreground disabled:pointer-events-none disabled:opacity-50 group-has-data-[sidebar=menu-action]/menu-item:pr-8 aria-disabled:pointer-events-none aria-disabled:opacity-50 data-[active=true]:bg-sidebar-accent data-[active=true]:font-medium data-[active=true]:text-sidebar-accent-foreground data-[state=open]:hover:bg-sidebar-accent data-[state=open]:hover:text-sidebar-accent-foreground group-data-[collapsible=icon]:size-8! group-data-[collapsible=icon]:p-2! [&>span:last-child]:truncate [&>svg]:size-4 [&>svg]:shrink-0',
368+
'peer/menu-button flex w-full items-center gap-2 overflow-hidden rounded-lg p-2 text-left text-sm outline-hidden ring-sidebar-ring transition-[width,height,padding] hover:bg-sidebar-accent hover:text-sidebar-accent-foreground focus-visible:ring-2 active:bg-sidebar-accent active:text-sidebar-accent-foreground disabled:pointer-events-none disabled:opacity-50 disabled:cursor-not-allowed group-has-data-[sidebar=menu-action]/menu-item:pr-8 aria-disabled:pointer-events-none aria-disabled:opacity-50 data-[active=true]:bg-sidebar-accent data-[active=true]:font-medium data-[active=true]:text-sidebar-accent-foreground data-[state=open]:hover:bg-sidebar-accent data-[state=open]:hover:text-sidebar-accent-foreground group-data-[collapsible=icon]:size-8! group-data-[collapsible=icon]:p-2! [&>span:last-child]:truncate [&>svg]:size-4 [&>svg]:shrink-0 cursor-pointer',
369369
{
370370
variants: {
371371
variant: {

apps/mail/components/voice-button.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export function VoiceButton() {
2929
if (!isConnected) {
3030
return (
3131
<motion.div initial={{ scale: 0 }} animate={{ scale: 1 }} exit={{ scale: 0 }}>
32-
<button type="button" onClick={handleStartConversation}>
32+
<button type="button" onClick={handleStartConversation} className="cursor-pointer">
3333
<div className="dark:bg[#141414] flex h-7 items-center justify-center rounded-sm bg-[#262626] px-2">
3434
<Mic className="h-4 w-4 text-white dark:text-[#929292]" />
3535
</div>
@@ -40,7 +40,7 @@ export function VoiceButton() {
4040

4141
return (
4242
isConnected && (
43-
<button type="button" onClick={endConversation}>
43+
<button type="button" onClick={endConversation} className="cursor-pointer">
4444
<div className="dark:bg[#141414] flex h-7 items-center justify-center rounded-sm bg-[#262626] px-2">
4545
{isInitializing && (
4646
<div className="flex items-center justify-center gap-2">

package.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,9 @@
5252
"typescript": "catalog:"
5353
},
5454
"dependencies": {
55-
"zod-to-json-schema": "3.24.6",
56-
"zod": "4.1.1"
55+
"drizzle-kit": "catalog:",
56+
"react-router": "^7.6.3",
57+
"zod": "4.1.1",
58+
"zod-to-json-schema": "3.24.6"
5759
}
5860
}

pnpm-lock.yaml

Lines changed: 7 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)