Skip to content

Commit 5304600

Browse files
authored
fix: fix proxy protocol check (#414)
* fix: fix proxy protocol check Signed-off-by: fastlorenzo <git@bernardi.be> * fix: check also the proxyProtocol enablement flag Signed-off-by: fastlorenzo <git@bernardi.be> --------- Signed-off-by: fastlorenzo <git@bernardi.be>
1 parent 4d0fd58 commit 5304600

1 file changed

Lines changed: 14 additions & 14 deletions

File tree

charts/mailu/templates/_services.tpl

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -213,41 +213,41 @@ Service fqdn (within cluster) can be retrieved with `mailu.SERVICE.serviceFqdn`
213213
{{- $proxyProtocolPorts := list -}}
214214

215215
{{- if .Values.front.externalService.enabled -}}
216-
{{- if .Values.front.externalService.ports.pop3 -}}
216+
{{- if and .Values.front.externalService.ports.pop3 .Values.ingress.proxyProtocol.pop3 -}}
217217
{{- $proxyProtocolPorts = append $proxyProtocolPorts "110" -}}
218218
{{- end -}}
219-
{{- if .Values.front.externalService.ports.pop3s -}}
219+
{{- if and .Values.front.externalService.ports.pop3s .Values.ingress.proxyProtocol.pop3s -}}
220220
{{- $proxyProtocolPorts = append $proxyProtocolPorts "995" -}}
221221
{{- end -}}
222-
{{- if .Values.front.externalService.ports.imap -}}
222+
{{- if and .Values.front.externalService.ports.imap .Values.ingress.proxyProtocol.imap -}}
223223
{{- $proxyProtocolPorts = append $proxyProtocolPorts "143" -}}
224224
{{- end -}}
225-
{{- if .Values.front.externalService.ports.imaps -}}
225+
{{- if and .Values.front.externalService.ports.imaps .Values.ingress.proxyProtocol.imaps -}}
226226
{{- $proxyProtocolPorts = append $proxyProtocolPorts "993" -}}
227227
{{- end -}}
228-
{{- if .Values.front.externalService.ports.smtp -}}
228+
{{- if and .Values.front.externalService.ports.smtp .Values.ingress.proxyProtocol.smtp -}}
229229
{{- $proxyProtocolPorts = append $proxyProtocolPorts "25" -}}
230230
{{- end -}}
231-
{{- if .Values.front.externalService.ports.smtps -}}
231+
{{- if and .Values.front.externalService.ports.smtps .Values.ingress.proxyProtocol.smtps -}}
232232
{{- $proxyProtocolPorts = append $proxyProtocolPorts "465" -}}
233233
{{- end -}}
234-
{{- if .Values.front.externalService.ports.submission -}}
234+
{{- if and .Values.front.externalService.ports.submission .Values.ingress.proxyProtocol.submission -}}
235235
{{- $proxyProtocolPorts = append $proxyProtocolPorts "587" -}}
236236
{{- end -}}
237-
{{- if .Values.front.externalService.ports.manageSieve -}}
237+
{{- if and .Values.front.externalService.ports.manageSieve .Values.ingress.proxyProtocol.manageSieve -}}
238238
{{- $proxyProtocolPorts = append $proxyProtocolPorts "4190" -}}
239239
{{- end -}}
240240
{{- end -}}
241241

242242
{{- $proxyProtocolPortsString := join "," $proxyProtocolPorts -}}
243-
{{/* if any ports are enabled and .front.realIpFrom is empty, fail */}}
244-
{{- if and (gt (len $proxyProtocolPorts) 0) (not .Values.front.realIpFrom) -}}
245-
{{- fail "PROXY protocol is enabled for some ports, but front.realIpFrom is not set" -}}
243+
{{/* if any ports are enabled and .ingress.realIpFrom is empty, fail */}}
244+
{{- if and (gt (len $proxyProtocolPorts) 0) (not .Values.ingress.realIpFrom) -}}
245+
{{- fail "PROXY protocol is enabled for some ports, but ingress.realIpFrom is not set" -}}
246246
{{- end -}}
247247

248-
{{/* if any ports are enabled and .front.realIpHeader is set, fail */}}
249-
{{- if and (gt (len $proxyProtocolPorts) 0) .Values.front.realIpHeader -}}
250-
{{- fail "PROXY protocol is enabled for some ports, but front.realIpHeader is set" -}}
248+
{{/* if any ports are enabled and .ingress.realIpHeader is set, fail */}}
249+
{{- if and (gt (len $proxyProtocolPorts) 0) .Values.ingress.realIpHeader -}}
250+
{{- fail "PROXY protocol is enabled for some ports, but ingress.realIpHeader is set" -}}
251251
{{- end -}}
252252

253253
{{- printf "%s" $proxyProtocolPortsString -}}

0 commit comments

Comments
 (0)