Fix rendering of LaTeXString when using bracket (#5536)

* Fix bracket text to support LaTeXStrings

The text type annotation was forcing LaTeXString to convert to String,
which caused LaTeX expressions like L"u(x) = \sin(x)" to render as
literal text with dollar signs instead of mathematical notation.

Changed text_pos type from Tuple{String, Point2f} to
Tuple{Union{String, LaTeXStrings.LaTeXString}, Point2f}

* Add bracket plot tests with LaTeXString support

Adds new test file test/plots/bracket.jl containing tests to verify
that LaTeX strings are properly preserved in bracket text, including:
- Regular strings still work
- LaTeXStrings are preserved as LaTeXString type
- Mixed vectors preserve individual element types

* Update changelog

* import LaTeXStrings in test

* import LaTeXStrings from Makie

* include RichText

Co-authored-by: Henrik Wolf <49985053+henrik-wolf@users.noreply.github.com>

* check child text plot for string type and test for rich text

* update bracket reftest to use LaTeXString and RichText

* correct placement of changelog entry after merge

---------

Co-authored-by: Henrik Wolf <49985053+henrik-wolf@users.noreply.github.com>
Co-authored-by: Frederic Freyer <frederic481994@hotmail.de>

Author: 3 people

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## Unreleased
 
+- Fixed `bracket` not supporting `LaTeXString` text, which would render with dollar signs instead of mathematical notation [#5536](https://github.com/MakieOrg/Makie.jl/pull/5536)
 - Added text glow to CairoMakie [#5542](https://github.com/MakieOrg/Makie.jl/pull/5542)
 - Allow to set low or high bound of the colorrange and let the other side stay adaptive [#5555](https://github.com/MakieOrg/Makie.jl/pull/5555)
 - Barplot `bar_labels` now support `RichText` (e.g. subscript/superscript) both directly and via `label_formatter` [#5578](https://github.com/MakieOrg/Makie.jl/pull/5578)

Makie/src/basic_recipes/bracket.jl

@@ -131,7 +131,7 @@ function plot!(pl::Bracket)
 
         # TODO: add a broadcast/map version of broadcast_foreach doing this:
         bps = BezierPath[]
-        text_pos = Tuple{String, Point2f}[]
+        text_pos = Tuple{Union{String, LaTeXStrings.LaTeXString, RichText}, Point2f}[]
 
         broadcast_foreach(startpoints, endpoints, directions, offset, width, style, text) do p1, p2, dir, offset, width, style, str
             off = offset * dir

Makie/test/plots/bracket.jl

@@ -0,0 +1,30 @@
+using Makie.LaTeXStrings
+@testset "bracket" begin
+    @testset "LaTeXString support" begin
+        # Test that LaTeX strings are preserved in bracket text child plot's input_text
+        fig = Figure()
+        ax = Axis(fig[1, 1])
+
+        # Regular string should work - check child text plot's input_text
+        b1 = bracket!(ax, 0, 0, 1, 0, text = "regular text")
+        @test b1.plots[2].input_text[][1] isa String
+
+        # LaTeX string should be preserved as LaTeXString in child text plot's input_text
+        latex_str = L"u(x) = \sin(x)"
+        b2 = bracket!(ax, 1, 0, 2, 0, text = latex_str)
+        @test b2.plots[2].input_text[][1] isa LaTeXString
+
+        # Mixed vector should preserve types in child text plot's input_text
+        texts = ["regular", L"\alpha + \beta"]
+        b3 = bracket!(ax, [0, 1], [0.5, 0.5], [1, 2], [0.5, 0.5], text = texts)
+        @test b3.plots[2].input_text[][1] isa String
+        @test b3.plots[2].input_text[][2] isa LaTeXString
+
+        richtext = rich(
+            "H", subscript("2"), "O is the formula for ",
+            rich("water", color = :cornflowerblue, font = :italic)
+        )
+        b4 = bracket!(ax, 0.0, 0.1, 1, 0.1, text = richtext)
+        @test b4.plots[2].input_text[][1] isa Makie.RichText
+    end
+end

Makie/test/runtests.jl

@@ -41,6 +41,7 @@ end
         include("plots/generic_attributes.jl")
         include("plots/text.jl")
         include("plots/barplot.jl")
+        include("plots/bracket.jl")
         include("plots/hist.jl")
         include("plots/poly.jl")
         include("plots/voronoiplot.jl")

ReferenceTests/src/tests/examples2d.jl

@@ -1214,10 +1214,10 @@ end
     f, ax, l = lines(0 .. 9, sin; axis = (; xgridvisible = false, ygridvisible = false))
     ylims!(ax, -1.5, 1.5)
 
-    bracket!(pi / 2, 1, 5pi / 2, 1, offset = 5, text = "Period length", style = :square)
+    bracket!(pi / 2, 1, 5pi / 2, 1, offset = 5, text = L"\text{Period length}\,\mathcal{T} = 2\pi", style = :square)
 
     bracket!(
-        pi / 2, 1, pi / 2, -1, text = "Amplitude", orientation = :down,
+        pi / 2, 1, pi / 2, -1, text = rich(rich("Amp", color = :red, font = :bold), rich("litude", color = :darkred)), orientation = :down,
         linestyle = :dash, rotation = 0, align = (:right, :center), textoffset = 4, linewidth = 2, color = :red, textcolor = :red
     )