Merge pull request #9979 from GilbertCherrie/delete_unused_dependencies

Delete unused packages

Author: asirvadAbrahamVarghese

app/javascript/spec/helpers/codemirrorRangeMock.js

@@ -0,0 +1,22 @@
+// TODO: Can be removed when we upgrade CodeMirror to version 6 after changing react-codemirror2 to react-codemirror
+// Mock Range.prototype methods for CodeMirror
+if (typeof Range !== 'undefined' && !Range.prototype.getBoundingClientRect) {
+  Range.prototype.getBoundingClientRect = () => ({
+    bottom: 0,
+    height: 0,
+    left: 0,
+    right: 0,
+    top: 0,
+    width: 0,
+    x: 0,
+    y: 0,
+    toJSON: () => {},
+  });
+}
+
+if (typeof Range !== 'undefined' && !Range.prototype.getClientRects) {
+  Range.prototype.getClientRects = () => ({
+    length: 0,
+    item: () => null,
+  });
+}

app/javascript/spec/helpers/mockAsyncRequest.js

@@ -7,6 +7,7 @@ import '../helpers/miqFlashLater';
 import '../helpers/miqSparkle';
 import '../helpers/miqAjaxButton';
 import '../helpers/sprintf';
+import '../helpers/codemirrorRangeMock';
 import { mount } from '../helpers/mountForm';
 
 import OrcherstrationTemplateForm from '../../components/orchestration-template/orcherstration-template-form';
@@ -33,7 +34,7 @@ describe('OrcherstrationTemplate form', () => {
     addFlashSpy.mockRestore();
   });
 
-  it('should call submit function', async(done) => {
+  it('should call submit function', async() => {
     fetchMock.postOnce('/api/orchestration_templates', {});
     let wrapper;
     await act(async() => {
@@ -58,10 +59,9 @@ describe('OrcherstrationTemplate form', () => {
       content: 'Some random content',
     }));
     expect(sparkleOnSpy).toHaveBeenCalledTimes(1);
-    done();
   });
 
-  it('should call miqFlashLater on cancel action', async(done) => {
+  it('should call miqFlashLater on cancel action', async() => {
     let wrapper;
     await act(async() => {
       wrapper = mount(<OrcherstrationTemplateForm {...initialProps} />);
@@ -77,10 +77,9 @@ describe('OrcherstrationTemplate form', () => {
       'success',
       '/catalog/explorer',
     );
-    done();
   });
 
-  it('should render edit variant', async(done) => {
+  it('should render edit variant', async() => {
     const sparkleOnSpy = jest.spyOn(window, 'miqSparkleOn');
     fetchMock.patchOnce('/api/orchestration_templates/123', {});
     fetchMock.getOnce('/api/orchestration_templates/123?attributes=name,description,type,ems_id,draft,content', {
@@ -104,10 +103,9 @@ describe('OrcherstrationTemplate form', () => {
       content: 'content',
     }));
     expect(sparkleOnSpy).toHaveBeenCalledTimes(1);
-    done();
   });
 
-  it('should render copy variant', async(done) => {
+  it('should render copy variant', async() => {
     const sparkleOnSpy = jest.spyOn(window, 'miqSparkleOn');
     fetchMock.postOnce('/api/orchestration_templates/123', {});
     fetchMock.getOnce('/api/orchestration_templates/123?attributes=name,description,type,ems_id,draft,content', {
@@ -141,7 +139,6 @@ describe('OrcherstrationTemplate form', () => {
       },
     }));
     expect(sparkleOnSpy).toHaveBeenCalledTimes(1);
-    done();
   });
 });
 
@@ -167,7 +164,7 @@ describe('Orcherstration Stack form', () => {
     spyMiqAjaxButton.mockRestore();
   });
 
-  it('should render copy variant', async(done) => {
+  it('should render copy variant', async() => {
     const sparkleOnSpy = jest.spyOn(window, 'miqSparkleOn');
     fetchMock.postOnce('/api/orchestration_templates/123', {});
     fetchMock.getOnce('/api/orchestration_templates/123?attributes=name,description,type,ems_id,draft,content', {
@@ -195,10 +192,9 @@ describe('Orcherstration Stack form', () => {
     expect(fetchMock.lastCall()).toBeTruthy();
     expect(sparkleOnSpy).toHaveBeenCalledTimes(1);
     expect(wrapper).toMatchSnapshot();
-    done();
   });
 
-  it('should call submit function', async(done) => {
+  it('should call submit function', () => {
     const addContent = {
       templateId: 123,
       templateName: 'template_name',
@@ -209,16 +205,14 @@ describe('Orcherstration Stack form', () => {
 
     miqAjaxButton(`/orchestration_stack/stacks_ot_copy?button=add`, addContent);
     expect(spyMiqAjaxButton).toHaveBeenCalledWith('/orchestration_stack/stacks_ot_copy?button=add', addContent);
-    done();
   });
 
-  it('should call cancel function', async(done) => {
+  it('should call cancel function', () => {
     const cancelMessage = __('Copy of Orchestration Template was cancelled by the user');
     miqRedirectBack(cancelMessage, 'success', `/orchestration_stack/show/${123}?display=stack_orchestration_template#/`);
 
     expect(miqRedirectBack).toHaveBeenCalledWith(
       cancelMessage, 'success', `/orchestration_stack/show/${123}?display=stack_orchestration_template#/`
     );
-    done();
   });
 });

app/javascript/spec/orchestration-template/orchestration-template-form.spec.js

@@ -4,11 +4,11 @@ import fetchMock from 'fetch-mock';
 
 import { act } from 'react-dom/test-utils';
 import '../helpers/miqSparkle';
+import '../helpers/codemirrorRangeMock';
 import { mount } from '../helpers/mountForm';
 import PxeCustomizationTemplateForm from '../../components/pxe-customization-template-form/index';
 
 describe('Pxe Customization Template Form Component', () => {
-
   const api = {
     resources: [
       {
@@ -35,44 +35,41 @@ describe('Pxe Customization Template Form Component', () => {
     fetchMock.restore();
   });
 
-  it('should render adding a new pxe customization template', async (done) => {
+  it('should render adding a new pxe customization template', async() => {
     fetchMock.get('/api/pxe_image_types?attributes=name,id&expand=resources', api);
     let wrapper;
 
-    await act(async () => {
+    await act(async() => {
       wrapper = mount(<PxeCustomizationTemplateForm />);
     });
     wrapper.update();
     expect(fetchMock.calls()).toHaveLength(2);
     expect(toJson(wrapper)).toMatchSnapshot();
-    done();
   });
 
-  it('should render editing a pxe customization template', async (done) => {
+  it('should render editing a pxe customization template', async() => {
     fetchMock.get('/api/pxe_image_types?attributes=name,id&expand=resources', api);
     fetchMock.get('/api/customization_templates/1', editOrCopyObject);
     let wrapper;
 
-    await act(async () => {
+    await act(async() => {
       wrapper = mount(<PxeCustomizationTemplateForm recordId="1" />);
     });
     wrapper.update();
     expect(fetchMock.calls()).toHaveLength(3);
     expect(toJson(wrapper)).toMatchSnapshot();
-    done();
   });
 
-  it('should render copying a pxe customization template', async (done) => {
+  it('should render copying a pxe customization template', async() => {
     fetchMock.get('/api/pxe_image_types?attributes=name,id&expand=resources', api);
     fetchMock.get('/api/customization_templates/1', editOrCopyObject);
     let wrapper;
 
-    await act(async () => {
+    await act(async() => {
       wrapper = mount(<PxeCustomizationTemplateForm copy="1" />);
     });
     wrapper.update();
     expect(fetchMock.calls()).toHaveLength(3);
     expect(toJson(wrapper)).toMatchSnapshot();
-    done();
   });
 });

app/javascript/spec/pxe-customization-template-form/pxe-customization-template-form.spec.js

@@ -3,7 +3,6 @@ import { mount } from 'enzyme';
 import fetchMock from 'fetch-mock';
 import { act } from 'react-dom/test-utils';
 
-import './helpers/mockAsyncRequest';
 import './helpers/miqSparkle';
 
 import ReportDataTable from '../components/data-tables/report-data-table/report-data-table';

app/javascript/spec/report-data-table.spec.js

@@ -121,9 +121,6 @@ module.exports = {
       }, {}
     ),
     'shims': [
-      'es6-shim',
-      'array-includes',
-      'whatwg-fetch',
       'core-js/stable',
       'regenerator-runtime/runtime',
     ],

config/webpack/shared.js

@@ -53,18 +53,15 @@
     "angular-patternfly": "~3.26.0",
     "angular-ui-bootstrap": "~2.5.6",
     "angular-ui-sortable": "~0.19.0",
-    "array-includes": "^3.1.9",
     "awesome-debounce-promise": "^2.1.0",
     "bootstrap-filestyle": "~1.2.1",
     "bootstrap-select": "^1.13.18",
     "bootstrap-switch": "3.3.4",
     "classnames": "~2.5.0",
     "codemirror": "~5.65.0",
     "connected-react-router": "~6.9.0",
-    "create-react-context": "~0.3.0",
     "d3": "^7.8.2",
     "dompurify": "^3.3.2",
-    "es6-shim": "~0.35.8",
     "history": "^4.7.2",
     "jquery": "~2.2.4",
     "jquery-ui": "~1.14.0",
@@ -99,8 +96,6 @@
     "spice-html5-bower": "~1.7.3",
     "spin.js": "~4.1.0",
     "sprintf-js": "~1.1.1",
-    "table-resolver": "^4.1.1",
-    "ui-select": "0.19.8",
     "whatwg-fetch": "~3.6.20",
     "xml_display": "~0.1.1"
   },
@@ -142,7 +137,6 @@
     "imports-loader": "~0.8.0",
     "jasmine-jquery": "~2.1.1",
     "jest": "~26.6.3",
-    "jest-cli": "^25.5.3",
     "js-yaml": "~3.14.0",
     "ng-annotate-loader": "~0.7.0",
     "node-fetch": "~2.7.0",