Merge pull request #21790 from jrafanie/fix_fallout_from_deleting_failed_deployments

Fix fallout from deleting failed deployments

Author: agrare

app/models/miq_server/worker_management/kubernetes.rb

@@ -52,7 +52,13 @@ def sync_deployment_settings
 
       if deployment_resource_constraints_changed?(worker)
         _log.info("Constraints changed, patching deployment: [#{worker.worker_deployment_name}]")
-        worker.patch_deployment
+
+        begin
+          worker.patch_deployment
+        rescue => err
+          _log.warn("Failure patching deployment: [#{worker.worker_deployment_name}] for worker: id: [#{worker.id}], system_uid: [#{worker.system_uid}]. Error: [#{err}]... skipping")
+          next
+        end
       end
       checked_deployments << worker.worker_deployment_name
     end

spec/models/miq_server/worker_management/kubernetes_spec.rb

@@ -351,6 +351,15 @@
       expect(worker3).to receive(:patch_deployment)
       server.worker_manager.sync_deployment_settings
     end
+
+    it "skips worker classes missing their deployment" do
+      allow(server.worker_manager).to receive(:miq_workers).and_return([worker1, worker3])
+      allow(server.worker_manager).to receive(:deployment_resource_constraints_changed?).with(worker1).and_return(true)
+      allow(server.worker_manager).to receive(:deployment_resource_constraints_changed?).with(worker3).and_return(true)
+      allow(worker1).to receive(:patch_deployment).and_raise(StandardError.new("AHHHHHH!"))
+      expect(worker3).to receive(:patch_deployment)
+      server.worker_manager.sync_deployment_settings
+    end
   end
 
   context "deployment_resource_constraints_changed?" do