Able to perform VM operations on retired VMs

[Aditi336]

Description:
In ManageIQ, users are able to perform VM operations (such as power-on and power-off) on retired VMs. This affects a mixture of AIX, Linux, and IBMi systems. Retired VMs should not allow lifecycle operations, but they remain accessible for such actions.

Steps to Reproduce:

• Navigate to the Providers in the dashboard.
  

• Navigate to System.
  

• Select the VM you want to retire.
  

• Go to Lifecycle Operations and choose Retire Selected Items from the dropdown. 
  

• After retirement, attempt to perform power-on/power-off operations on the VM.
  

Expected Behavior:
Retired VMs should not allow lifecycle operations such as power-on or power-off.

Actual Behavior:
Users are still able to perform power-on/power-off operations on retired VMs.

Video link: https://ibm.box.com/s/iqjx3vto6lfoewz5vr5k49qn6iisu3vy

[Fryguy]

@Aditi336 Is this only for a specific provider? (IBM Power HMC or other?)

[Aditi336]

@Fryguy it is specific to IBM Power HMC

[agrare]

I believe the problem is you override the supports :control feature in your Vm subclass: https://github.com/ManageIQ/manageiq-providers-ibm_power_hmc/blob/master/app/models/manageiq/providers/ibm_power_hmc/infra_manager/vm.rb#L9-L11

This bypasses all of the other checks by the base VmOrTemplate::Operations control feature including a retired/archived check: https://github.com/ManageIQ/manageiq/blob/master/app/models/vm_or_template/operations.rb#L134-L148

Recommend that you fix this in the HMC VM subclass.