fix: Strip section prefix from env-var keys so WEB_* settings actually load

_load_from_env stored env-var keys lowercased verbatim, so WEB_HOST
became {"web": {"web_host": ...}} while Web.__init__ reads
web_config.get("host", ...). Result: WEB_ENABLED, WEB_HOST, WEB_PORT,
WEB_DB_PATH all silently no-op'd when configured via environment
variables — the values were loaded into the dict but under keys
nothing actually reads. PROXY_PREFIX was the only web env var that
worked, because its name doesn't start with the WEB_ prefix.

Practical impact: env-var deployments could not change the listen
address, port, database path, or even disable the web UI — every
WEB_ENABLED=false ran the UI anyway. Verified empirically before fix.

Strip the section-name prefix from env-var keys when storing in
_load_from_env so they match the YAML schema. This is surgical:
no other section uses an env-var prefix matching its name, so the
behavior of general/jobs/instances/download_clients is unchanged.

Add a parametrized regression test covering all five web env vars,
including a value (WEB_ENABLED=false) that differs from the default
so a no-op fix would be caught.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: lolimmlost

src/settings/_user_config.py

@@ -81,6 +81,11 @@ def _load_from_env() -> dict:
 
     for section, keys in CONFIG_MAPPING.items():
         section_config = {}
+        # Some env vars are prefixed with the section name to keep deployment
+        # docs unambiguous (e.g. WEB_HOST vs the bare HOST). Strip that prefix
+        # when storing so the resulting keys match the YAML schema (`host`,
+        # not `web_host`) and downstream classes find them.
+        section_prefix = section.upper() + "_"
 
         for key in keys:
             env_key = key if os.getenv(key) is not None else key.lower()
@@ -96,7 +101,8 @@ def _load_from_env() -> dict:
                     f"Failed to parse environment variable {key} as YAML:\n{e}",
                 )
                 parsed_value = {}
-            section_config[key.lower()] = parsed_value
+            stored_key = key[len(section_prefix):] if key.startswith(section_prefix) else key
+            section_config[stored_key.lower()] = parsed_value
 
         config[section] = section_config
 

tests/settings/test_user_config_from_env.py

@@ -87,6 +87,11 @@ def fixture_env_vars():
         "RADARR": radarr_yaml,
         "SONARR": sonarr_yaml,
         "QBITTORRENT": qbit_yaml,
+        "WEB_ENABLED": "false",
+        "WEB_HOST": "127.0.0.1",
+        "WEB_PORT": "8080",
+        "PROXY_PREFIX": "decluttarr",
+        "WEB_DB_PATH": "/data/custom.db",
     }
     with patch.dict(os.environ, env, clear=True):
         yield env
@@ -119,6 +124,13 @@ def fixture_env_vars():
         ("instances", "radarr", radarr_expected),
         ("instances", "sonarr", sonarr_expected),
         ("download_clients", "qbittorrent", qbit_expected),
+        # Web env vars: section prefix (WEB_) is stripped on load so the keys
+        # match the YAML schema. PROXY_PREFIX has no prefix and stays as-is.
+        ("web", "enabled", False),
+        ("web", "host", "127.0.0.1"),
+        ("web", "port", 8080),
+        ("web", "proxy_prefix", "decluttarr"),
+        ("web", "db_path", "/data/custom.db"),
     ],
 )
 def test_env_loading_parametrized(