Merge pull request #203 from ManoManoTech/fix/early-closure-validation

fix: Allow early closure from OPEN/INVESTIGATING without key events validation

Author: NicolasLafitteMM

src/firefighter/slack/views/modals/closure_reason.py

@@ -115,20 +115,25 @@ def handle_modal_fn(  # type: ignore[override]
         self, ack: Ack, body: dict[str, Any], incident: Incident, user: User
     ) -> bool | None:
         """Handle the closure reason modal submission."""
-        # Early validation: Check if incident can be closed BEFORE calling ack()
-        # This validation happens BEFORE ack() so we can display errors in the modal
-        can_close, reasons = incident.can_be_closed
-        if not can_close:
-            # Build error message from reasons
-            error_messages = [reason[1] for reason in reasons]
-            error_text = "\n".join([f"• {msg}" for msg in error_messages])
-            ack(
-                response_action="errors",
-                errors={
-                    "closure_message": f"Cannot close this incident:\n{error_text}"
-                }
-            )
-            return False
+        # For early closure (OPEN/INVESTIGATING), we bypass normal workflow checks
+        # For normal closure (MITIGATED/POST_MORTEM), we must validate key events
+        current_status = incident.status
+        is_early_closure = current_status.value in {IncidentStatus.OPEN, IncidentStatus.INVESTIGATING}
+
+        if not is_early_closure:
+            # Normal closure path - validate that incident can be closed
+            can_close, reasons = incident.can_be_closed
+            if not can_close:
+                # Build error message from reasons
+                error_messages = [reason[1] for reason in reasons]
+                error_text = "\n".join([f"• {msg}" for msg in error_messages])
+                ack(
+                    response_action="errors",
+                    errors={
+                        "closure_message": f"Cannot close this incident:\n{error_text}"
+                    }
+                )
+                return False
 
         # Clear ALL modals in the stack (not just this one)
         # This ensures the underlying "Update Status" modal is also closed