fix(apple): support non-unique UDIDs

Malinskiy · Malinskiy · commit f8a595796a24 · 2024-02-24T21:59:09.000+10:00
diff --git a/vendor/vendor-apple/ios/src/main/kotlin/com/malinskiy/marathon/apple/ios/device/AppleSimulatorProvider.kt b/vendor/vendor-apple/ios/src/main/kotlin/com/malinskiy/marathon/apple/ios/device/AppleSimulatorProvider.kt
@@ -328,7 +328,8 @@ class AppleSimulatorProvider(
     }
 
     private fun connect(transport: Transport, device: AppleSimulatorDevice) {
-        devices.put(device.udid, device)
+        //Should not use udid as key here to support multiple devices with the same udid across transports
+        devices.put(device.serialNumber, device)
             ?.let {
                 logger.error("replaced existing device $it with new $device.")
                 dispose(it)

Original file line number	Diff line number	Diff line change
`@@ -328,7 +328,8 @@ class AppleSimulatorProvider(`
`328`	`328`	`}`
`329`	`329`
`330`	`330`	`private fun connect(transport: Transport, device: AppleSimulatorDevice) {`
`331`		`- devices.put(device.udid, device)`
	`331`	`+ //Should not use udid as key here to support multiple devices with the same udid across transports`
	`332`	`+ devices.put(device.serialNumber, device)`
`332`	`333`	`?.let {`
`333`	`334`	`logger.error("replaced existing device $it with new $device.")`
`334`	`335`	`dispose(it)`