copilot feedback

Author: MarcSkovMadsen

.github/workflows/ci.yml

@@ -118,14 +118,16 @@ jobs:
         uses: actions/cache@v4
         with:
           path: ~/.holoviz-mcp-test
-          key: holoviz-mcp-test-index-${{ runner.os }}-${{ hashFiles('src/holoviz_mcp/config/config.yaml') }}-${{ steps.cache-week.outputs.week }}
+          key: holoviz-mcp-test-index-${{ runner.os }}-${{ hashFiles('src/holoviz_mcp/config/config.yaml', 'src/holoviz_mcp/holoviz_mcp/data.py') }}-${{ steps.cache-week.outputs.week }}
           restore-keys: |
-            holoviz-mcp-test-index-${{ runner.os }}-${{ hashFiles('src/holoviz_mcp/config/config.yaml') }}-
+            holoviz-mcp-test-index-${{ runner.os }}-${{ hashFiles('src/holoviz_mcp/config/config.yaml', 'src/holoviz_mcp/holoviz_mcp/data.py') }}-
             holoviz-mcp-test-index-${{ runner.os }}-
       - name: Install repository
         run: pixi run -e ${{ matrix.environment }} postinstall
-      - name: Run pytest
-        run: pixi run -e ${{ matrix.environment }} test-coverage --color=yes
+      - name: Run unit tests (fast)
+        run: pixi run -e ${{ matrix.environment }} pytest tests/ --ignore=tests/docs_mcp --color=yes
+      - name: Run docs integration tests (slow, uses cached index)
+        run: pixi run -e ${{ matrix.environment }} pytest tests/docs_mcp --color=yes
 
   pytest_ui:
     name: ui:${{ matrix.environment }}:${{ matrix.os }}

AGENTS.md

@@ -11,7 +11,7 @@ A README for AI coding agents to effectively contribute to the HoloViz MCP proje
 **Language**: Python 3.11+
 **Build System**: Pixi (conda-based) + Hatchling (PEP 517)
 **Framework**: FastMCP (Python MCP SDK)
-**Key Dependencies**: ChromaDB, sentence-transformers, Panel, PyTorch
+**Key Dependencies**: ChromaDB, sentence-transformers, Panel
 
 ### Project Statistics
 - **Source Files**: ~20 Python modules in `src/holoviz_mcp/`
@@ -564,7 +564,7 @@ First-time indexing takes 5-10 minutes:
 
 ### Memory Usage
 
-Heavy dependencies (PyTorch, sentence-transformers):
+Heavy dependencies (sentence-transformers, ChromaDB):
 - **Development**: ~2-4 GB RAM
 - **Running server**: ~1-2 GB RAM
 - **Indexing docs**: ~3-5 GB RAM (temporary spike)

pyproject.toml

@@ -176,6 +176,9 @@ filterwarnings = [
     "ignore::UserWarning",
 ]
 testpaths = ["tests"]
+markers = [
+    "integration: marks tests that require the documentation index (slow)",
+]
 
 [tool.codespell]
 ignore-words-list = "acn"

tests/docs_mcp/conftest.py

@@ -7,6 +7,7 @@
 
 import asyncio
 import logging
+import os
 from pathlib import Path
 
 import pytest
@@ -16,8 +17,9 @@
 
 logger = logging.getLogger(__name__)
 
-# Fixed test directory (not tmp_path) so CI can cache the index across runs
-TEST_DATA_DIR = Path.home() / ".holoviz-mcp-test"
+# Fixed test directory (not tmp_path) so CI can cache the index across runs.
+# Override with HOLOVIZ_MCP_TEST_DIR for custom locations or concurrent sessions.
+TEST_DATA_DIR = Path(os.environ["HOLOVIZ_MCP_TEST_DIR"]) if "HOLOVIZ_MCP_TEST_DIR" in os.environ else Path.home() / ".holoviz-mcp-test"
 
 # Only these projects are needed by test assertions
 TEST_PROJECTS = ("panel", "hvplot", "panel-material-ui")
@@ -31,8 +33,11 @@ def _build_test_config():
     loader = ConfigLoader(config=env)
     default_config = loader.load_config()
 
-    # Keep only the repos needed for tests
-    test_repos = {name: default_config.docs.repositories[name] for name in TEST_PROJECTS if name in default_config.docs.repositories}
+    # Validate that all expected test repos exist in the default config
+    missing = set(TEST_PROJECTS) - set(default_config.docs.repositories)
+    if missing:
+        raise RuntimeError(f"TEST_PROJECTS not found in default config: {missing}")
+    test_repos = {name: default_config.docs.repositories[name] for name in TEST_PROJECTS}
 
     test_docs = default_config.docs.model_copy(update={"repositories": test_repos})
     test_server = default_config.server.model_copy(update={"vector_db_path": TEST_DATA_DIR / "vector_db" / "chroma"})
@@ -47,7 +52,7 @@ def _build_test_config():
     )
 
 
-@pytest.fixture(scope="session", autouse=True)
+@pytest.fixture(scope="package", autouse=True)
 def docs_test_config():
     """Patch get_config() to use a minimal 3-repo test config for the session.
 

tests/docs_mcp/test_docs_mcp.py

@@ -19,6 +19,7 @@ async def test_skills_resource():
         assert result.data
 
 
+@pytest.mark.integration
 @pytest.mark.skip(reason="this test is very slow")
 @pytest.mark.asyncio
 async def test_update_index():
@@ -29,6 +30,7 @@ async def test_update_index():
         assert result.data
 
 
+@pytest.mark.integration
 @pytest.mark.asyncio
 async def test_list_projects():
     """Test that all projects are listed correctly."""
@@ -40,6 +42,7 @@ async def test_list_projects():
     assert "panel" in result.data
 
 
+@pytest.mark.integration
 @pytest.mark.asyncio
 async def test_semantic_search():
     """Test the search tool."""
@@ -63,6 +66,7 @@ async def test_semantic_search():
             assert "content" in document
 
 
+@pytest.mark.integration
 @pytest.mark.asyncio
 async def test_search_by_project():
     """Test the search tool with project filtering."""
@@ -78,6 +82,7 @@ async def test_search_by_project():
             assert document["project"] == "hvplot"
 
 
+@pytest.mark.integration
 @pytest.mark.asyncio
 async def test_search_with_custom_max_results():
     """Test the search tool with custom max_results parameter."""
@@ -95,6 +100,7 @@ async def test_search_with_custom_max_results():
             assert document["project"] == "panel"
 
 
+@pytest.mark.integration
 @pytest.mark.asyncio
 async def test_search_without_content():
     """Test the search tool with content=False for metadata only."""
@@ -116,6 +122,7 @@ async def test_search_without_content():
             assert document.get("content") is None
 
 
+@pytest.mark.integration
 @pytest.mark.asyncio
 async def test_search_material_ui_specific():
     """Test the search tool with Material UI specific query."""
@@ -131,6 +138,7 @@ async def test_search_material_ui_specific():
             assert document["project"] == "panel-material-ui"
 
 
+@pytest.mark.integration
 @pytest.mark.asyncio
 async def test_search_empty_query():
     """Test the search tool with edge cases."""
@@ -142,6 +150,7 @@ async def test_search_empty_query():
         assert isinstance(result.data, list)
 
 
+@pytest.mark.integration
 @pytest.mark.asyncio
 async def test_search_invalid_project():
     """Test the search tool with invalid project name."""
@@ -154,6 +163,7 @@ async def test_search_invalid_project():
         assert len(result.data) == 0
 
 
+@pytest.mark.integration
 @pytest.mark.asyncio
 async def test_search_with_project_filter():
     """Test the search tool with project filtering."""

tests/docs_mcp/test_docs_mcp_reference_guide.py

@@ -9,6 +9,8 @@
 
 from holoviz_mcp.holoviz_mcp.server import mcp
 
+pytestmark = pytest.mark.integration
+
 
 @pytest.mark.asyncio
 async def test_get_reference_guide_button_no_project():

tests/docs_mcp/test_tabulator_truncation.py

@@ -14,6 +14,8 @@
 from holoviz_mcp.holoviz_mcp.data import DocumentationIndexer
 from holoviz_mcp.holoviz_mcp.data import truncate_content
 
+pytestmark = pytest.mark.integration
+
 
 class TestTabulatorTruncation:
     """Test suite for Tabulator reference guide context-aware truncation."""