Skip to content

Commit 9f59338

Browse files
authored
Apply suggestions from code review
Co-authored-by: Andrew <15331990+ahuang11@users.noreply.github.com>
1 parent 9178552 commit 9f59338

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

skills/review/SKILL.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,5 @@ Perform a `git diff` from the PR branch to the main branch, and review the code
1212
- [ ] DO place imports at the top of the file; DON'T place imports inside functions unless there is a specific reason (slow import, circular import, etc.).
1313
- [ ] DO consider the full set of changes and whether there is a more efficient or cleaner way to achieve the same result.
1414
- [ ] DO use consistent and readable naming conventions, e.g., if `FollowUpSuggestion` is used, the variable name should be `follow_up_suggestion`, not `followup_suggestion` or `follow_up_suggestions` (plural)
15-
- [ ] if necessary, ensure the feature or enhancement documented in the docs
16-
- [ ] avoid implicit boolean checks on pandas objects, e.g. `if df`, `if df == obj`, etc
15+
- [ ] DO ensure the feature or enhancement documented in the docs
16+
- [ ] DO NOT use implicit boolean checks on pandas objects, e.g. `if df`, `if df == obj`, etc

0 commit comments

Comments
 (0)