Skip to content

Commit bcca720

Browse files
docs: make minor comment improvements [ci skip]
1 parent 62fc61b commit bcca720

3 files changed

Lines changed: 9 additions & 11 deletions

File tree

.github/workflows/deploy.yml

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# The GitHub Actions file
22

3+
# This is based on the knetminer-ci template, see there for details.
4+
35
name: Standard Build
46

57
on:
@@ -55,15 +57,11 @@ jobs:
5557
key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }}
5658
restore-keys: ${{ runner.os }}-m2
5759

58-
# Avoids re-listing all the secrets again. As they recommend, use the commit hash to point to
59-
# an exact version, using tags might be compromised by malicious commits.
60-
#
61-
# See knetminer-ci docs for a list of secrets and other variables we use.
62-
#
63-
- name: Forward all GH secrets to env
64-
uses: oNaiPs/secrets-to-env-action@75f319b3c8c926ac2eabcca34daa6cf531daf32f
65-
with:
66-
secrets: ${{ toJSON(secrets) }}
60+
- name: Forward secrets to env vars
61+
env:
62+
_SECRETS_JS_STR: ${{ toJSON(secrets) }}
63+
run: |
64+
echo "$_SECRETS_JS_STR" | jq -r 'to_entries[] | "\(.key)<<EOF\n\(.value)\nEOF"' >> $GITHUB_ENV
6765
6866
- name: Build
6967
# You still need this for variables that aren't secrets, but better than nothing

ci-build-v2/java-maven/build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ function stage_build_local
2121

2222
printf "== Installing ci-build scripts and then running the build\n"
2323

24-
# TODO: DO USE a version tag in place of main, DO MAKE your builds stable and predictable
24+
# DO USE a version tag in place of main, DO MAKE your builds stable and predictable
2525
ci_build_url_base="https://raw.githubusercontent.com/KnetMiner/knetminer-ci/refs/tags/1.0"
2626
script_url="$ci_build_url_base/ci-build-v2/install.sh"
2727
. <(curl --fail-with-body -o - "$script_url") "$ci_build_url_base" java-maven

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@
219219
uk.ac.ebi.utils.opt.json
220220
-->
221221
<dependency>
222-
<groupId> tools.jackson.dataformat </groupId>
222+
<groupId>tools.jackson.dataformat</groupId>
223223
<artifactId>jackson-dataformat-yaml</artifactId>
224224
<version>3.1.2</version>
225225
</dependency>

0 commit comments

Comments
 (0)