Exception Occurs When Executing CloseAsync() and Dispose() Method

[YamamotoYuma9]

Based on the API documentation available at
https://vnc-client.marcusw.de/apidoc/api/MarcusW.VncClient.RfbConnection.html#methods,
I attempted to disconnect from the server using two methods bellow, however, both methods resulted in an exception being raised:

• RfbConnection.CloseAsync()
  

• RfbConnection.Dispose().
  

with:
RfbConnection = await _connectionManager.ConnectAsync(parameters, cancellationToken).ConfigureAwait(true);
(Source:

MarcusW.VncClient/samples/AvaloniaVncClient/ViewModels/MainWindowViewModel.cs

Line 93 in 9d9fbf7

RfbConnection = await _connectionManager.ConnectAsync(parameters, cancellationToken).ConfigureAwait(true);

)

I'm uncertain whether my implementation is incorrect or if the two methods mentioned above are not fully implemented yet.

[MarcusWichelmann]

That an OperationCanceledException gets thrown may happen in this case. But if you catch it, it should be fine.

[AlexanderNorup]

That an OperationCanceledException gets thrown may happen in this case. But if you catch it, it should be fine.
@MarcusWichelmann

You can't just catch the exception, because you use ThreadStart to start the background thread. So the background thread will always just throw and break your entire application whenever you call CloseAsync().
You'd have need to catch the exception from the background-job code.

[MarcusWichelmann]

@AlexanderNorup Oh, okay. I've not looked into that codebase for quite some time now. That's very unfortunate.

Then forget about what I said. 😅

I'm on vacation for a few weeks, but if someone wants to do a PR for that, I'll look into it.

[matthijslz]

Just dropping a comment here to let you know that I've been having the same issues. The changes proposed by Alexander in #26 solve these issues for me as well 👍