Start applying Pylint Warning rules (PLW) (skrub-data#1711)

Author: DimitriPapadopoulos

benchmarks/utils/join.py

@@ -67,7 +67,7 @@ def fetch_data(
     if len(file_paths) == 0:
         repository = "Yeye-He/Auto-Join"
         dataset_name = dataset_name.replace(" ", "%20")
-        base_url = base_url = (
+        base_url = (
             "https://raw.githubusercontent.com/"
             f"{repository}/master/autojoin-Benchmark/{dataset_name}"
         )

benchmarks/utils/monitor.py

@@ -248,10 +248,9 @@ def exec_func(**kwargs):
                         for key, value in result_mapping.items():
                             results[key].append(value)
 
-                else:
-                    # Accessing the upper-level variable, kind of hackish,
-                    # but cleanest in terms of code.
-                    progress_bar.update(1)
+                # Accessing the upper-level variable, kind of hackish,
+                # but cleanest in terms of code.
+                progress_bar.update(1)
 
                 # Global cleanup of monitored values
                 if memory:

skrub/_data_ops/_data_ops.py

@@ -296,7 +296,7 @@ def _find_dataframe(data_op, func_name):
     # Eg skrub.X().join(actual_df, ...) instead of skrub.X().join(skrub.var('Z'), ...)
     from ._evaluation import find_arg
 
-    df = find_arg(data_op, lambda o: sbd.is_dataframe(o))
+    df = find_arg(data_op, sbd.is_dataframe)
     if df is not None:
         return {
             "message": (

skrub/datasets/_utils.py

@@ -329,10 +329,9 @@ def _download_archive(
         time.sleep(delay)
         delay *= 3
 
-    else:
-        raise OSError(
-            f"Can't download the file {dataset_name!r} from urls {metadata['urls']}."
-        )
+    raise OSError(
+        f"Can't download the file {dataset_name!r} from urls {metadata['urls']}."
+    )
 
 
 def _stream_download(