#4622 Implement virtual OnDeserialized methods (#4662)

Author: rockfordlhotka

Source/Csla.test/Serialization/SerializationTests.cs

@@ -651,6 +651,16 @@ public void TimeOnlySerialization()
       var clone = obj.Clone();
       Assert.AreEqual(obj.TimeOnly, clone.TimeOnly);
     }
+
+    [TestMethod]
+    public void NotifyOnDeserializationTest()
+    {
+      var portal = _testDIContext.CreateDataPortal<NotifyOnDeserialization>();
+      var obj = portal.Create();
+      obj.Data = "test data";
+      var clone = obj.Clone();
+      Assert.AreEqual("OnDeserialized", TestResults.GetResult("OnDeserialized"));
+    }
   }
 
   [Serializable]
@@ -712,4 +722,22 @@ private void Create()
     { }
   }
 
+  [Serializable]
+  public class NotifyOnDeserialization : BusinessBase<NotifyOnDeserialization>
+  {
+    public static readonly PropertyInfo<string> DataProperty = RegisterProperty<string>(nameof(Data));
+    public string Data
+    {
+      get => GetProperty(DataProperty);
+      set => SetProperty(DataProperty, value);
+    }
+    [Create]
+    private void Create()
+    { }
+    protected override void OnDeserialized()
+    {
+      base.OnDeserialized();
+      TestResults.AddOrOverwrite("OnDeserialized", "OnDeserialized");
+    }
+  }
 }

Source/Csla/Core/BusinessBase.cs

@@ -1424,6 +1424,15 @@ void ISerializationNotification.Deserialized()
         FieldManager.SetPropertyList(GetType());
       InitializeBusinessRules();
       FieldDataDeserialized();
+      OnDeserialized();
+    }
+
+    /// <summary>
+    /// Invoked after the object has been deserialized.
+    /// </summary>
+    protected virtual void OnDeserialized()
+    {
+      // do nothing by default
     }
 
     #endregion

Source/Csla/Core/ExtendedBindingList.cs

@@ -279,8 +279,18 @@ void ISerializationNotification.Deserialized()
       // don't rehook events here, because the MobileFormatter has
       // created new objects and so the lists will auto-subscribe
       // the events;
+      OnDeserialized();
     }
 
+    /// <summary>
+    /// Invoked after the object has been deserialized.
+    /// </summary>
+    protected virtual void OnDeserialized()
+    {
+      // do nothing by default
+    }
+
+
     [NonSerialized]
     [NotUndoable]
     private EventHandler<ChildChangedEventArgs> _childChangedHandlers;

Source/Csla/Core/ObservableBindingList.cs

@@ -382,8 +382,18 @@ void ISerializationNotification.Deserialized()
       // don't rehook events here, because the MobileFormatter has
       // created new objects and so the lists will auto-subscribe
       // the events
+      OnDeserialized();
     }
 
+    /// <summary>
+    /// Invoked after the object has been deserialized.
+    /// </summary>
+    protected virtual void OnDeserialized()
+    {
+      // do nothing by default
+    }
+
+
     #endregion
 
     #region Child Change Notification

Source/Csla/ReadOnlyBase.cs

@@ -511,16 +511,19 @@ protected virtual void Child_OnDataPortalException(DataPortalEventArgs e, Except
     #region Serialization Notification
 
     void ISerializationNotification.Deserialized()
-    {
-      OnDeserializedHandler(new System.Runtime.Serialization.StreamingContext());
-    }
-
-    [System.Runtime.Serialization.OnDeserialized]
-    private void OnDeserializedHandler(System.Runtime.Serialization.StreamingContext context)
     {
       if (_fieldManager != null)
         FieldManager.SetPropertyList(GetType());
       InitializeBusinessRules();
+      OnDeserialized();
+    }
+
+    /// <summary>
+    /// Invoked after the object has been deserialized.
+    /// </summary>
+    protected virtual void OnDeserialized()
+    {
+      // do nothing by default
     }
 
 

Source/Csla/Rules/BusinessRules.cs

@@ -1302,15 +1302,19 @@ protected override void OnSetChildren(SerializationInfo info, MobileFormatter fo
 
     void ISerializationNotification.Deserialized()
     {
-      OnDeserializedHandler(new System.Runtime.Serialization.StreamingContext());
+      SyncRoot = LockFactory.Create();
+      OnDeserialized();
     }
 
-    [System.Runtime.Serialization.OnDeserialized]
-    private void OnDeserializedHandler(System.Runtime.Serialization.StreamingContext context)
+    /// <summary>
+    /// Invoked after the object has been deserialized.
+    /// </summary>
+    protected virtual void OnDeserialized()
     {
-      SyncRoot = LockFactory.Create();
+      // do nothing by default
     }
 
+
     #endregion
 
     #region Get All Broken Rules (tree)