Should AllowNew be checked in AddNewCore?

[hurcane]

We have business use cases where list contents are editable, but the list items are fixed. This is accomplished by setting AllowNew = false; and AllowRemove= false; in the relevant create methods. However, a call to AddNew() successfully returns a new item that is added to the collection.

I was able to confirm this behavior with the following test added to the CollectionTests fixture, which tests BindingListBase.

[TestMethod]
public void AllowNewFalse()
{
  TestCollection list = CreateTestCollection();
  list.AllowNew = false;
  Assert.IsFalse(list.AllowNew, "AllowNew should be false");
  try
  {
    list.AddNew();
    Assert.Fail("Should not be able to add new item");
  }
  catch (NotSupportedException)
  {
    // expected exception
  }
}

The test reaches the Assert.Fail() line. A similar test in BasicModernTests has the same behavior with the BusinessListBase.

Should the framework be checking the property, or should it be the responsibility of the developer to override the relevant methods to actively prevent new items from being added to the list?

[rockfordlhotka]

This sounds like a bug to me. I'm surprised that there's not an existing check in AddNew to prevent this issue.

Can you file this as a bug issue please?