Make ByFactory.button use exact text match (jenkinsci#2621)

Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>

Author: Harmit07

src/main/java/org/jenkinsci/test/acceptance/ByFactory.java

@@ -173,7 +173,7 @@ private static String fieldXPath(String base, String locator) {
      */
     public By button(String locator) {
         return xpath(
-                ".//input[./@type = 'submit' or ./@type = 'reset' or ./@type = 'image' or ./@type = 'button'][((./@id = '%1$s' or ./@name = '%1$s' or contains(./@value, '%1$s')) or contains(./@title, '%1$s'))] | .//input[./@type = 'image'][contains(./@alt, '%1$s')] | .//button[(((./@id = '%1$s' or contains(./@value, '%1$s')) or contains(normalize-space(.), '%1$s')) or contains(./@title, '%1$s'))] | .//input[./@type = 'image'][contains(./@alt, '%1$s')]",
+                ".//input[./@type = 'submit' or ./@type = 'reset' or ./@type = 'image' or ./@type = 'button'][./@id = '%1$s' or ./@name = '%1$s' or ./@value = '%1$s' or ./@title = '%1$s'] | .//input[./@type = 'image'][./@alt = '%1$s'] | .//button[./@id = '%1$s' or ./@value = '%1$s' or normalize-space(.) = '%1$s' or ./@title = '%1$s'] | .//input[./@type = 'image'][./@alt = '%1$s']",
                 locator);
     }
 

src/main/java/org/jenkinsci/test/acceptance/plugins/ssh_slaves/SshSlaveLauncher.java

@@ -37,7 +37,9 @@ public SshSlaveLauncher(PageObject context, String path) {
     public <T extends Credential> T addCredential(Class<T> type) {
         find(by.button("Add")).click();
 
-        find(by.css(".jenkins-dropdown")).findElement(by.button("Global")).click();
+        find(by.css(".jenkins-dropdown"))
+                .findElement(by.button("GlobalCredentials that should be available everywhere."))
+                .click();
 
         // Selenium will execute the next step before the options have loaded if we don't wait for them
         waitFor(by.css(".jenkins-choice-list__item__label"));

src/main/java/org/jenkinsci/test/acceptance/po/Node.java

@@ -82,7 +82,8 @@ public String runScript(String script, int timeoutSeconds, Object... args) {
         visit("script");
         CodeMirror cm = new CodeMirror(this, "/script");
         cm.set(String.format(script, args));
-        find(by.css("button[value='Run']")).click();
+
+        clickButton("Run");
 
         waitFor(by.xpath("//h2[contains(text(), 'Result')]"), timeoutSeconds);