implemented delay to Keyboard Key press

Author: Snooz82

Browser/keywords/interaction.py

@@ -1318,19 +1318,23 @@ def mouse_wheel(self, deltaX: int, deltaY: int):
             logger.info(response.log)
 
     @keyword(tags=("Setter", "PageContent"))
-    def keyboard_key(self, action: KeyAction, key: str):
+    def keyboard_key(
+        self, action: KeyAction, key: str, *, delay: timedelta = timedelta(0)
+    ):
         """Press a keyboard key on the virtual keyboard or set a key up or down.
 
         | =Arguments= | =Description= |
         | ``action`` | Determines whether the key should be released (``up``), held down (``down``) or pressed once (``press``). ``down`` and ``up`` are useful for combinations, i.e. with Shift. |
         | ``key`` | The key to be pressed. Examples of valid keys are: ``F1`` - ``F12``, ``Digit0`` - ``Digit9``, ``KeyA`` - ``KeyZ``, ``Backquote``, ``Minus``, ``Equal``, ``Backslash``, ``Backspace``, ``Tab``, ``Delete``, ``Escape``, ``ArrowDown``, ``End``, ``Enter``, ``Home``, ``Insert``, ``PageDown``, ``PageUp``, ``ArrowRight``, ``ArrowUp`` , etc. |
+        | ``delay`` | Time the key is held down between keydown and keyup, in Robot Framework's time format. Only valid with action ``press``, other actions raise an error. Defaults to ``0 s``. Example: ``50 ms`` |
 
 
         Useful keys for ``down`` and ``up`` for example are:
         ``Shift``, ``Control``, ``Alt``, ``Meta``, ``ShiftLeft``
 
         Example execution:
         | `Keyboard Key`    press    S
+        | `Keyboard Key`    press    S        delay=500 ms
         | `Keyboard Key`    down     Shift
         | `Keyboard Key`    press    ArrowLeft
         | `Keyboard Key`    press    Delete
@@ -1340,9 +1344,15 @@ def keyboard_key(self, action: KeyAction, key: str):
 
         [https://forum.robotframework.org/t//4298|Comment >>]
         """
+        if delay and action is not KeyAction.press:
+            raise ValueError("delay is only valid if action is 'press'")
         with self.playwright.grpc_channel() as stub:
             response = stub.KeyboardKey(
-                Request().KeyboardKeypress(action=action.name, key=key)
+                Request().KeyboardKeypress(
+                    action=action.name,
+                    key=key,
+                    delay=int(delay.total_seconds() * 1000),
+                )
             )
             logger.debug(response.log)
 

atest/test/02_Content_Keywords/virtual_keyboard.robot

@@ -20,3 +20,27 @@ Select List Options
     Keyboard Key    press    ArrowDown
     Keyboard Key    press    ArrowDown
     Get Selected Options    select[name="possible_channels"]    value    ==    email    phone    directmail
+
+Keyboard Key Press Holds The Key For The Given Delay
+    [Setup]    New Page    ${EVENTS_URL}
+    Click    id=event_log_clear
+    Click    id=event_test_input
+    Keyboard Key    press    a    delay=200 ms
+    ${log} =    Get Text    id=event_log_text
+    Assert Key Timings    ${log}    a    expected_press_duration_ms=200ms
+
+Keyboard Key Press Without Delay Does Not Hold The Key
+    [Setup]    New Page    ${EVENTS_URL}
+    Click    id=event_log_clear
+    Click    id=event_test_input
+    Keyboard Key    press    b
+    ${log} =    Get Text    id=event_log_text
+    Assert Key Timings    ${log}    b    expected_press_duration_ms=0
+
+Keyboard Key Delay Is Only Valid For Press
+    Run Keyword And Expect Error
+    ...    ValueError: delay is only valid if action is 'press'
+    ...    Keyboard Key    down    Shift    delay=100 ms
+    Run Keyword And Expect Error
+    ...    ValueError: delay is only valid if action is 'press'
+    ...    Keyboard Key    up    Shift    delay=100 ms

node/playwright-wrapper/interaction.ts

@@ -302,6 +302,11 @@ export async function mouseWheel(request: pb.Request_MouseWheel, page?: Page): P
 export async function keyboardKey(request: pb.Request_KeyboardKeypress, page: Page): Promise<pb.Response_Empty> {
     const action = request.action as 'down' | 'up' | 'press';
     const key = request.key;
+    const delay = request.delay;
+    if (action === 'press' && delay > 0) {
+        await invokeOnKeyboard(page, action, key, { delay: delay });
+        return emptyWithLog(`Successfully did ${action} for ${key} with delay ${delay}ms`);
+    }
     await invokeOnKeyboard(page, action, key);
     return emptyWithLog(`Successfully did ${action} for ${key}`);
 }

protobuf/playwright.proto

@@ -178,6 +178,7 @@ message Request {
   message KeyboardKeypress {
     string action = 1;
     string key = 2;
+    int32 delay = 3;
   }
 
   message KeyboardInputOptions {