[BUG] DWIN ProUI: error: 'PROBE_OFFSET_ZMIN' was not declared in this scope

[CRCinAU]

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

When building without a probe, ProUI fails to build with the following error:

Marlin/src/lcd/e3v2/proui/dwin.cpp: In function 'void setZOffset()':
Marlin/src/lcd/e3v2/proui/dwin.cpp:2068:22: error: 'PROBE_OFFSET_ZMIN' was not declared in this scope
2068 |     setPFloatOnClick(PROBE_OFFSET_ZMIN, PROBE_OFFSET_ZMAX, 2, applyZOffset, liveZOffset);
|                      ^~~~~~~~~~~~~~~~~
Marlin/src/lcd/e3v2/proui/dwin.cpp:2068:41: error: 'PROBE_OFFSET_ZMAX' was not declared in this scope
2068 |     setPFloatOnClick(PROBE_OFFSET_ZMIN, PROBE_OFFSET_ZMAX, 2, applyZOffset, liveZOffset);
|                                         ^~~~~~~~~~~~~~~~~
*** [.pio/build/STM32F103RE_creality/src/src/lcd/e3v2/proui/dwin.cpp.o] Error 1

The following patch fixes the define, but this is probably not the ideal fix:

diff --git a/Marlin/src/lcd/e3v2/proui/dwin.h b/Marlin/src/lcd/e3v2/proui/dwin.h
index 9c11cc4916..1f366f12d9 100644
--- a/Marlin/src/lcd/e3v2/proui/dwin.h
+++ b/Marlin/src/lcd/e3v2/proui/dwin.h
@@ -46,6 +46,13 @@
#endif
#endif

+#ifndef PROBE_OFFSET_ZMIN
+  #define PROBE_OFFSET_ZMIN  -10 // (mm)
+#endif
+#ifndef PROBE_OFFSET_ZMAX
+  #define PROBE_OFFSET_ZMAX   10 // (mm)
+#endif
+
namespace GET_LANG(LCD_LANGUAGE) {
#define _MSG_PREHEAT(N) \
LSTR MSG_PREHEAT_##N                  = _UxGT("Preheat ") PREHEAT_## N ##_LABEL; \

Something in the build pre-processing is removing the definition of PROBE_OFFSET_ZMIN that is still required within ProUI for systems that do not have a probe.

As such, the above patch isn't a solution, but a workaround to at least get a successful compile.

Bug Timeline

No response

Expected behavior

No response

Actual behavior

No response

Steps to Reproduce

No response

Version of Marlin Firmware

bugfix-2.1.x

Printer model

No response

Electronics

No response

LCD/Controller

No response

Other add-ons

No response

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

• A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

No response

[classicrocker883]

in Marlin\src\inc\Conditionals_LCD.h
you can look for and add line ~1460

/**
 * Conditionals based on the type of Bed Probe
 */
...
#if HAS_BED_PROBE
...
#else
  // Clear probe pin settings when no probe is selected
...
  #if DISABLED(DWIN_LCD_PROUI)
    #undef PROBE_OFFSET_ZMIN
    #undef PROBE_OFFSET_ZMAX
  #endif

or comment it out

  #undef MULTIPLE_PROBING
  #undef EXTRA_PROBING
- #undef PROBE_OFFSET_ZMIN
- #undef PROBE_OFFSET_ZMAX
+ //#undef PROBE_OFFSET_ZMIN
+ //#undef PROBE_OFFSET_ZMAX
  #undef PAUSE_BEFORE_DEPLOY_STOW
  #undef PAUSE_PROBE_DEPLOY_WHEN_TRIGGERED

[thisiskeithb]

Hopefully the probe requirement can be removed in #26502 and these UIs will start following what users have enabled in their config instead of assuming specific hardware/features are always enabled.