Drop Python 3.8 support; upgrade websockets lib to v15 (#605)

Author: zzstoatzz

.github/workflows/codegen.yml

@@ -34,7 +34,7 @@ jobs:
       - name: Set up Python.
         uses: actions/setup-python@v4
         with:
-          python-version: '3.8'
+          python-version: '3.9'
 
       - name: Setup Poetry.
         uses: snok/install-poetry@v1

.github/workflows/publish_release.yml

@@ -32,7 +32,7 @@ jobs:
       - name: Setup Python.
         uses: actions/setup-python@v4
         with:
-          python-version: 3.8
+          python-version: 3.9
 
       - name: Setup Poetry.
         uses: snok/install-poetry@v1

.github/workflows/ruff.yml

@@ -24,7 +24,7 @@ jobs:
       - name: Setup Python.
         uses: actions/setup-python@v4
         with:
-          python-version: 3.8
+          python-version: 3.9
 
       - name: Run linter check.
         uses: astral-sh/ruff-action@v3

.github/workflows/test.yml

@@ -10,7 +10,7 @@ jobs:
     strategy:
       matrix:
         os: [ macos-latest, ubuntu-latest, windows-latest ]
-        python-version: [ "3.8", "3.9", "3.10", "3.11", "3.12", "3.13" ]
+        python-version: [ "3.9", "3.10", "3.11", "3.12", "3.13" ]
 
     runs-on: ${{matrix.os}}
 

.github/workflows/update_lexicons.yml

@@ -28,7 +28,7 @@ jobs:
       - name: Set up Python.
         uses: actions/setup-python@v4
         with:
-          python-version: '3.8'
+          python-version: '3.9'
 
       - name: Setup Poetry.
         uses: snok/install-poetry@v1

.readthedocs.yaml

@@ -7,7 +7,7 @@ version: 2
 build:
   os: ubuntu-20.04
   tools:
-    python: "3.8"
+    python: "3.9"
   jobs:
     post_create_environment:
       - python -m pip install poetry

README.md

@@ -83,7 +83,7 @@ This SDK attempts to implement everything that provides ATProto. There is suppor
 
 ### Requirements
 
-- Python 3.8 or higher.
+- Python 3.9 or higher.
 
 ### Installing
 

docs/source/readme.content.md

@@ -4,7 +4,7 @@ This SDK attempts to implement everything that provides ATProto. There is suppor
 
 ### Requirements
 
-- Python 3.8 or higher.
+- Python 3.9 or higher.
 
 ### Installing
 

packages/atproto_firehose/client.py

@@ -11,7 +11,7 @@
 from atproto_client.models.base import ParamsModelBase
 from atproto_client.models.common import XrpcError
 from atproto_core.exceptions import DAGCBORDecodingError
-from websockets.client import connect as aconnect
+from websockets.asyncio.client import connect as aconnect
 from websockets.exceptions import (
     ConnectionClosedError,
     ConnectionClosedOK,
@@ -46,8 +46,8 @@
 
 
 if t.TYPE_CHECKING:
-    from websockets.client import ClientConnection as SyncWebSocketClient
-    from websockets.legacy.client import Connect as AsyncConnect
+    from websockets.asyncio.client import connect as AsyncConnect
+    from websockets.sync.client import ClientConnection as SyncWebSocketClient
 
 
 def _build_websocket_uri(method: str, base_uri: str, params: t.Optional[t.Dict[str, t.Any]] = None) -> str:
@@ -124,9 +124,18 @@ def _websocket_uri(self) -> str:
         return _build_websocket_uri(self._method, self._base_uri, self._params)
 
     def _get_client(self) -> 'SyncWebSocketClient':
-        return connect(self._websocket_uri, max_size=_MAX_MESSAGE_SIZE_BYTES, close_timeout=0.1)
+        # Disable automatic pings for sync client (added in websockets v15+)
+        # to maintain behavior consistent with <v14 for now.
+        return connect(
+            self._websocket_uri,
+            max_size=_MAX_MESSAGE_SIZE_BYTES,
+            close_timeout=0.1,
+            # see https://websockets.readthedocs.io/en/stable/topics/keepalive.html
+            ping_interval=None,  # Disable automatic pings
+        )
 
     def _get_async_client(self) -> 'AsyncConnect':
+        # Async client connect function accepts ping_interval directly (default is 20s)
         return aconnect(self._websocket_uri, max_size=_MAX_MESSAGE_SIZE_BYTES, close_timeout=0.1)
 
     def _get_reconnection_delay(self) -> int: