Skip to content

modify version comparison popup #264

Open

Description

@davidelang

the version comparison popup is comparing the wrong values
currently it compares something like:

FluidNC v1.14 (head-7fe778c0)
and
github.com/BarbourSmith/ESP3D-WEBUI@v1.14

in both the firmware and the UI there is a version that is defined to be git describe --always --tags --dirty
something like v1.14-6-g7fe778c0

change the version comparison to use these values instead of what is currently used.

Add a button to the popup to say 'don't warn until next release', and when that is hit, store the current versions in the preferences.json file and don't do another popup until one of the releases changes.

Also have a value for this saved versions of "do not alert" that will never generate a popup

add an entry to the preferences menu that shows the saved versions, and has a button to disable the popup (by saving 'do not alert' to the saved variable'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions