S5012793-Audience API Changes to For Sonar

Author: bhupendrae169407

src/main/java/com/mastercard/developer/validator/AudienceValidator.java

@@ -141,15 +141,14 @@ private void checkForEndDateTimeFormat(String endDateTime, Map<String, String> e
         }
     }
 
-    private void fromISOToLocalDateTime(String isoDateTime) {
-        if (isNotBlank(isoDateTime)) {
-            ZonedDateTime.parse(isoDateTime, DateTimeFormatter.ISO_DATE_TIME)
-                    .withZoneSameInstant(ZoneOffset.UTC);
-        }
+    private LocalDateTime fromISOToLocalDateTime(String isoDateTime) {
+        return isNotBlank(isoDateTime) ?
+                ZonedDateTime.parse(isoDateTime, DateTimeFormatter.ISO_DATE_TIME)
+                        .withZoneSameInstant(ZoneOffset.UTC).toLocalDateTime() : null;
     }
 
     private void collectAndThrowErrors(Map<String, String> errorMap) {
-        if (errorMap.size() > 0) {
+        if (!errorMap.isEmpty()) {
             final String[] mapKey = new String[1];
             errorMap.forEach((key, value) -> mapKey[0] = key);
             throw new InvalidRequest(mapKey[0], errorMap.get(mapKey[0]));

src/test/java/com/mastercard/developer/validator/AudienceValidatorTest.java

@@ -19,10 +19,7 @@
 @RunWith(MockitoJUnitRunner.class)
 public class AudienceValidatorTest {
 
-    private static final LocalDateTime BEGIN_DATE = LocalDateTime.now();
     private static final LocalDateTime END_DATE = LocalDateTime.now().plusDays(5);
-    private static final String BEGIN_DATE_TIME = BEGIN_DATE.atZone(ZoneOffset.UTC)
-            .withZoneSameInstant(ZoneOffset.UTC).format(DateTimeFormatter.ISO_DATE_TIME);
     private static final String END_DATE_TIME = END_DATE.atZone(ZoneOffset.UTC)
             .withZoneSameInstant(ZoneOffset.UTC).format(DateTimeFormatter.ISO_DATE_TIME);