Skip to content

Commit c720895

Browse files
authored
chore: Update MSRV to 1.91.0 (apache#2204)
## Which issue does this PR close? apache#2199 requires a bump to MSRV 1.91.0. This version is within the policy of this project. <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes #. ## What changes are included in this PR? <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> ## Are these changes tested? <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? -->
1 parent bc33657 commit c720895

File tree

5 files changed

+6
-11
lines changed

5 files changed

+6
-11
lines changed

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ version = "0.8.0"
3636
license = "Apache-2.0"
3737
repository = "https://github.com/apache/iceberg-rust"
3838
# Check the MSRV policy in README.md before changing this
39-
rust-version = "1.88"
39+
rust-version = "1.91"
4040

4141
[workspace.dependencies]
4242
anyhow = "1.0.72"

bindings/python/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
edition = "2024"
2020
homepage = "https://rust.iceberg.apache.org"
2121
name = "pyiceberg_core_rust"
22-
rust-version = "1.88"
22+
rust-version = "1.91"
2323
version = "0.8.0"
2424
# This crate is used to build python bindings, we don't want to publish it
2525
publish = false

crates/iceberg/src/spec/snapshot.rs

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,12 @@ pub const UNASSIGNED_SNAPSHOT_ID: i64 = -1;
3838

3939
/// Reference to [`Snapshot`].
4040
pub type SnapshotRef = Arc<Snapshot>;
41-
#[derive(Debug, Serialize, Deserialize, PartialEq, Eq, Clone)]
41+
#[derive(Debug, Default, Serialize, Deserialize, PartialEq, Eq, Clone)]
4242
#[serde(rename_all = "lowercase")]
4343
/// The operation field is used by some operations, like snapshot expiration, to skip processing certain snapshots.
4444
pub enum Operation {
4545
/// Only data files were added and no files were removed.
46+
#[default]
4647
Append,
4748
/// Data and delete files were added and removed without changing table data;
4849
/// i.e., compaction, changing the data file format, or relocating data files.
@@ -75,12 +76,6 @@ pub struct Summary {
7576
pub additional_properties: HashMap<String, String>,
7677
}
7778

78-
impl Default for Operation {
79-
fn default() -> Operation {
80-
Self::Append
81-
}
82-
}
83-
8479
#[derive(Debug, PartialEq, Eq, Clone)]
8580
/// Row range of a snapshot, contains first_row_id and added_rows_count.
8681
pub struct SnapshotRowRange {

crates/integrations/datafusion/src/physical_plan/scan.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ impl ExecutionPlan for IcebergTableScan {
126126
self
127127
}
128128

129-
fn children(&self) -> Vec<&Arc<(dyn ExecutionPlan + 'static)>> {
129+
fn children(&self) -> Vec<&Arc<dyn ExecutionPlan + 'static>> {
130130
vec![]
131131
}
132132

rust-toolchain.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,5 @@
2020
#
2121
# The channel is exactly same day for our MSRV.
2222
[toolchain]
23-
channel = "nightly-2025-06-23"
23+
channel = "nightly-2025-10-27"
2424
components = ["rustfmt", "clippy"]

0 commit comments

Comments
 (0)