Select RUF100 and drop the suppressions that suppress nothing

Of 38 `noqa` directives, 29 had no effect. They were invisible because the rule
that reports them was not selected, and they predate the ruff upgrade: version
0.0.292 reports the same 29.

Most are star imports annotated `F401 F403`. A star import triggers F403 and
never F401, so only the F403 half ever did anything, and those directives are
narrowed to it. Three name rules from families this repository does not select,
`SLF001`, `E731` and `BLE001`, are removed along with one blanket directive on
an import that is used. The eight that remain sit on genuine re-exports in
`mzexplore/__init__.py`, where F401 does fire.

Selecting RUF100 keeps the set honest, since a directive that stops applying now
fails the lint rather than accumulating.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: antiguru

misc/python/materialize/cli/mz_workload_anonymize_test.py

@@ -465,7 +465,7 @@ def cross_schema_cdc_workload() -> dict[str, Any]:
     schema. The child key is built in pass 1 while processing the source's
     schema (`aaa_src`), before the child's schema (`zzz_upstream`) is mapped, so
     a stale key leaks the original schema name unless rebuilt in pass 2."""
-    empty = lambda: {  # noqa: E731
+    empty = lambda: {
         "tables": {},
         "views": {},
         "materialized_views": {},

misc/python/materialize/cli/mzcompose.py

@@ -167,7 +167,7 @@ def main(argv: list[str]) -> None:
     # Convert to a list of the members: shtab renders them via str(), and
     # argparse still accepts the type-converted member, which converting to
     # name strings would not (the member never compares equal to its name).
-    for action in parser._actions:  # noqa: SLF001
+    for action in parser._actions:
         if isinstance(action.choices, type) and issubclass(action.choices, enum.Enum):
             action.choices = list(action.choices)
 

misc/python/materialize/scalability/executor/benchmark_executor.py

@@ -30,10 +30,10 @@
 from materialize.scalability.schema.schema import Schema
 from materialize.scalability.workload.workload import Workload, WorkloadWithContext
 from materialize.scalability.workload.workload_markers import ConnectionWorkload
-from materialize.scalability.workload.workloads.connection_workloads import *  # noqa: F401 F403
-from materialize.scalability.workload.workloads.ddl_workloads import *  # noqa: F401 F403
-from materialize.scalability.workload.workloads.dml_dql_workloads import *  # noqa: F401 F403
-from materialize.scalability.workload.workloads.self_test_workloads import *  # noqa: F401 F403
+from materialize.scalability.workload.workloads.connection_workloads import *  # noqa: F403
+from materialize.scalability.workload.workloads.ddl_workloads import *  # noqa: F403
+from materialize.scalability.workload.workloads.dml_dql_workloads import *  # noqa: F403
+from materialize.scalability.workload.workloads.self_test_workloads import *  # noqa: F403
 
 # number of retries in addition to the first run
 MAX_RETRIES_ON_REGRESSION = 2

misc/python/materialize/zippy/scenarios.py

@@ -18,7 +18,7 @@
 from materialize.zippy.blob_store_actions import BlobStoreRestart, BlobStoreStart
 from materialize.zippy.crdb_actions import CockroachRestart, CockroachStart
 from materialize.zippy.debezium_actions import CreateDebeziumSource, DebeziumStart
-from materialize.zippy.framework import ActionOrFactory  # noqa
+from materialize.zippy.framework import ActionOrFactory
 from materialize.zippy.kafka_actions import (
     CreateTopicParameterized,
     Ingest,

pyproject.toml

@@ -27,6 +27,7 @@ select = [
     "I",
     "UP", # e.g. PEP585 built-in generic type annotations
     "E711", # comparisons to none
+    "RUF100", # `noqa` that suppresses nothing, including for unselected rules
 ]
 
 [tool.ruff.lint.isort]

test/cloudtest/test_upgrade.py

@@ -14,7 +14,7 @@
 
 from materialize import buildkite
 from materialize.checks.actions import Action, Initialize, Manipulate, Validate
-from materialize.checks.all_checks import *  # noqa: F401 F403
+from materialize.checks.all_checks import *  # noqa: F403
 from materialize.checks.all_checks.alter_connection import (
     AlterConnectionHost,
     AlterConnectionToNonSsh,

test/data-ingest/mzcompose.py

@@ -21,7 +21,7 @@
     KafkaExecutor,
     MySqlExecutor,
 )
-from materialize.data_ingest.workload import *  # noqa: F401 F403
+from materialize.data_ingest.workload import *  # noqa: F403
 from materialize.data_ingest.workload import WORKLOADS, execute_workload
 from materialize.mzcompose import get_default_system_parameters
 from materialize.mzcompose.composition import Composition, WorkflowArgumentParser

test/feature-benchmark/mzcompose.py

@@ -72,17 +72,17 @@
 from materialize.feature_benchmark.executor import Docker
 from materialize.feature_benchmark.filter import Filter, FilterFirst, NoFilter
 from materialize.feature_benchmark.measurement import MeasurementType
-from materialize.feature_benchmark.scenarios.benchmark_main import *  # noqa: F401 F403
+from materialize.feature_benchmark.scenarios.benchmark_main import *  # noqa: F403
 from materialize.feature_benchmark.scenarios.benchmark_main import (
     Scenario,
 )
-from materialize.feature_benchmark.scenarios.concurrency import *  # noqa: F401 F403
-from materialize.feature_benchmark.scenarios.customer import *  # noqa: F401 F403
-from materialize.feature_benchmark.scenarios.optbench import *  # noqa: F401 F403
-from materialize.feature_benchmark.scenarios.scale import *  # noqa: F401 F403
-from materialize.feature_benchmark.scenarios.skew import *  # noqa: F401 F403
-from materialize.feature_benchmark.scenarios.subscribe import *  # noqa: F401 F403
-from materialize.feature_benchmark.scenarios.temporal import *  # noqa: F401 F403
+from materialize.feature_benchmark.scenarios.concurrency import *  # noqa: F403
+from materialize.feature_benchmark.scenarios.customer import *  # noqa: F403
+from materialize.feature_benchmark.scenarios.optbench import *  # noqa: F403
+from materialize.feature_benchmark.scenarios.scale import *  # noqa: F403
+from materialize.feature_benchmark.scenarios.skew import *  # noqa: F403
+from materialize.feature_benchmark.scenarios.subscribe import *  # noqa: F403
+from materialize.feature_benchmark.scenarios.temporal import *  # noqa: F403
 from materialize.feature_benchmark.termination import (
     NormalDistributionOverlap,
     ProbForMin,

test/mcp/mzcompose.py

@@ -1023,7 +1023,7 @@ def run(cur: Cursor, sql: str) -> str:
         """Run `sql`; return ``"ok:<nrows>"`` or the error message string."""
         try:
             cur.execute(sql.encode())
-        except Exception as e:  # noqa: BLE001 — the message is the assertion
+        except Exception as e:
             return str(e)
         if cur.description is None:
             return "ok:0"

test/parallel-benchmark/mzcompose.py

@@ -60,7 +60,7 @@
     SQLiteStore,
     State,
 )
-from materialize.parallel_benchmark.scenarios import *  # noqa: F401 F403
+from materialize.parallel_benchmark.scenarios import *  # noqa: F403
 from materialize.test_analytics.config.test_analytics_db_config import (
     create_test_analytics_config,
 )