adapter: remove unreachable code in statement_logging, for peek results

Author: aljoscha

src/adapter/src/statement_logging.rs

@@ -150,18 +150,8 @@ impl From<&ExecuteResponse> for StatementEndedExecutionReason {
     fn from(value: &ExecuteResponse) -> StatementEndedExecutionReason {
         match value {
             ExecuteResponse::CopyTo { resp, .. } => match resp.as_ref() {
-                // NB [btv]: It's not clear that this combination
-                // can ever actually happen.
                 ExecuteResponse::SendingRowsImmediate { rows, .. } => {
-                    // Note(parkmycar): It potentially feels bad here to iterate over the entire
-                    // iterator _just_ to get the encoded result size. As noted above, it's not
-                    // entirely clear this case ever happens, so the simplicity is worth it.
-                    let result_size: usize = rows.box_clone().map(|row| row.byte_len()).sum();
-                    StatementEndedExecutionReason::Success {
-                        result_size: Some(u64::cast_from(result_size)),
-                        rows_returned: Some(u64::cast_from(rows.count())),
-                        execution_strategy: Some(StatementExecutionStrategy::Constant),
-                    }
+                    panic!("SELECTs terminate on peek finalization, not here.")
                 }
                 ExecuteResponse::SendingRows { .. } => {
                     panic!("SELECTs terminate on peek finalization, not here.")
@@ -185,17 +175,7 @@ impl From<&ExecuteResponse> for StatementEndedExecutionReason {
             }
 
             ExecuteResponse::SendingRowsImmediate { rows, .. } => {
-                // Note(parkmycar): It potentially feels bad here to iterate over the entire
-                // iterator _just_ to get the encoded result size, the number of Rows returned here
-                // shouldn't be too large though. An alternative is to pre-compute some of the
-                // result size, but that would require always decoding Rows to handle projecting
-                // away columns, which has a negative impact for much larger response sizes.
-                let result_size: usize = rows.box_clone().map(|row| row.byte_len()).sum();
-                StatementEndedExecutionReason::Success {
-                    result_size: Some(u64::cast_from(result_size)),
-                    rows_returned: Some(u64::cast_from(rows.count())),
-                    execution_strategy: Some(StatementExecutionStrategy::Constant),
-                }
+                panic!("SELECTs terminate on peek finalization, not here.")
             }
 
             ExecuteResponse::AlteredDefaultPrivileges