Change environmentd_extra_args to accept list of strings

Author: bobbyiliev

README.md

@@ -77,7 +77,7 @@ No modules.
 | <a name="input_helm_repository"></a> [helm\_repository](#input\_helm\_repository) | Repository URL for the Materialize operator Helm chart. Leave empty if using local chart. | `string` | `"https://materializeinc.github.io/materialize/"` | no |
 | <a name="input_helm_values"></a> [helm\_values](#input\_helm\_values) | Values to pass to the Helm chart | `any` | n/a | yes |
 | <a name="input_install_metrics_server"></a> [install\_metrics\_server](#input\_install\_metrics\_server) | Whether to install the metrics-server | `bool` | `true` | no |
-| <a name="input_instances"></a> [instances](#input\_instances) | Configuration for Materialize instances | <pre>list(object({<br/>    name                 = string<br/>    namespace            = optional(string)<br/>    create_database      = optional(bool, true)<br/>    database_name        = string<br/>    metadata_backend_url = string<br/>    persist_backend_url  = string<br/>    license_key          = optional(string)<br/>    environmentd_version = optional(string, "v0.130.13") # META: mz version<br/>    environmentd_extra_env = optional(list(object({<br/>      name  = string<br/>      value = string<br/>    })), [])<br/>    environmentd_extra_args = optional(list(object({<br/>      name  = string<br/>      value = string<br/>    })), [])<br/>    cpu_request             = optional(string, "1")<br/>    memory_request          = optional(string, "1Gi")<br/>    memory_limit            = optional(string, "1Gi")<br/>    in_place_rollout        = optional(bool, true)<br/>    request_rollout         = optional(string, "00000000-0000-0000-0000-000000000001")<br/>    force_rollout           = optional(string, "00000000-0000-0000-0000-000000000001")<br/>    balancer_memory_request = optional(string, "256Mi")<br/>    balancer_memory_limit   = optional(string, "256Mi")<br/>    balancer_cpu_request    = optional(string, "100m")<br/>  }))</pre> | `[]` | no |
+| <a name="input_instances"></a> [instances](#input\_instances) | Configuration for Materialize instances | <pre>list(object({<br/>    name                 = string<br/>    namespace            = optional(string)<br/>    create_database      = optional(bool, true)<br/>    database_name        = string<br/>    metadata_backend_url = string<br/>    persist_backend_url  = string<br/>    license_key          = optional(string)<br/>    environmentd_version = optional(string, "v0.130.13") # META: mz version<br/>    environmentd_extra_env = optional(list(object({<br/>      name  = string<br/>      value = string<br/>    })), [])<br/>    environmentd_extra_args = optional(list(string), [])<br/>    cpu_request             = optional(string, "1")<br/>    memory_request          = optional(string, "1Gi")<br/>    memory_limit            = optional(string, "1Gi")<br/>    in_place_rollout        = optional(bool, true)<br/>    request_rollout         = optional(string, "00000000-0000-0000-0000-000000000001")<br/>    force_rollout           = optional(string, "00000000-0000-0000-0000-000000000001")<br/>    balancer_memory_request = optional(string, "256Mi")<br/>    balancer_memory_limit   = optional(string, "256Mi")<br/>    balancer_cpu_request    = optional(string, "100m")<br/>  }))</pre> | `[]` | no |
 | <a name="input_metrics_server_version"></a> [metrics\_server\_version](#input\_metrics\_server\_version) | Version of metrics-server to install | `string` | `"3.12.2"` | no |
 | <a name="input_monitoring_namespace"></a> [monitoring\_namespace](#input\_monitoring\_namespace) | Namespace for monitoring resources | `string` | `"monitoring"` | no |
 | <a name="input_namespace"></a> [namespace](#input\_namespace) | Namespace prefix for all resources | `string` | n/a | yes |

examples/aws/terraform.tfvars.example

@@ -1,4 +1,3 @@
-
 instance_configs_example = [
   {
     name              = "mz-instance-1"
@@ -10,6 +9,10 @@ instance_configs_example = [
     cpu_request      = "2"
     memory_request   = "4Gi"
     memory_limit     = "8Gi"
+    environmentd_extra_args = [
+      "--system-parameter-default=max_clusters=100",
+      "--system-parameter-default=max_connections=100"
+    ]
   },
   {
     name              = "mz-instance-2"

examples/gcp/terraform.tfvars.example

@@ -9,6 +9,10 @@ instance_configs_example = [
     cpu_request      = "2"
     memory_request   = "4Gi"
     memory_limit     = "8Gi"
+    environmentd_extra_args = [
+      "--system-parameter-default=max_clusters=100",
+      "--system-parameter-default=max_connections=100"
+    ]
   },
   {
     name              = "mz-instance-2"

main.tf

@@ -17,7 +17,7 @@ locals {
     for instance in var.instances : instance.name =>
     length(lookup(instance, "environmentd_extra_args", [])) > 0 ? [
       for item in instance.environmentd_extra_args :
-      "--system-parameter-default=${item.name}=${item.value}"
+      item
     ] : null
   }
 }

variables.tf

@@ -77,10 +77,7 @@ variable "instances" {
       name  = string
       value = string
     })), [])
-    environmentd_extra_args = optional(list(object({
-      name  = string
-      value = string
-    })), [])
+    environmentd_extra_args = optional(list(string), [])
     cpu_request             = optional(string, "1")
     memory_request          = optional(string, "1Gi")
     memory_limit            = optional(string, "1Gi")